From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] Make sure we copy all cpu_spec features except PMC related ones
Date: Mon, 23 Feb 2009 07:28:43 -0600 [thread overview]
Message-ID: <1235395723.11996.1.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <30c3ca265326d7aaa86cc75367d23739398a7b23.1235355941.git.michael@ellerman.id.au>
On Mon, 2009-02-23 at 13:25 +1100, Michael Ellerman wrote:
> When identify_cpu() is called a second time with a logical PVR, it
> only copies a subset of the cpu_spec fields so as to avoid overwriting
> the performance monitor fields that were initialized based on the
> real PVR.
>
> However some of the other, non performance monitor related fields are
> also not copied:
> * pvr_mask
> * pvr_value
> * mmu_features
> * machine_check
>
> The fact that pvr_mask is not copied can result in show_cpuinfo()
> showing the cpu as "unknown", if we override an unknown PVR with a
> logical one - as reported by Shaggy.
>
> So change the logic to copy all fields, and then put back the PMC
> related ones in the case that we're overwriting a real PVR with a
> logical one.
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2009-02-23 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 2:25 [PATCH 1/2] Deindentify identify_cpu() Michael Ellerman
2009-02-23 2:25 ` [PATCH 2/2] Make sure we copy all cpu_spec features except PMC related ones Michael Ellerman
2009-02-23 13:28 ` Dave Kleikamp [this message]
2009-02-23 13:27 ` [PATCH 1/2] Deindentify identify_cpu() Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235395723.11996.1.camel@norville.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox