From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/mm: Merge various PTE bits and accessors definitions
Date: Mon, 02 Mar 2009 18:57:52 +1100 [thread overview]
Message-ID: <1235980672.7248.4.camel@pasglop> (raw)
In-Reply-To: <1235979481.8526.31.camel@localhost>
On Mon, 2009-03-02 at 18:38 +1100, Michael Ellerman wrote:
> On Mon, 2009-03-02 at 17:22 +1100, Benjamin Herrenschmidt wrote:
> > Now that they are almost identical, we can merge some of the definitions
> > related to the PTE format into common files.
>
> <snip>
>
> > +/* Protection used for kernel text. We want the debuggers to be able to
> > + * set breakpoints anywhere, so don't write protect the kernel text
> > + * on platforms where such control is possible.
> > + */
> > +#if defined(CONFIG_KGDB) || defined(CONFIG_XMON) || defined(CONFIG_BDI_SWITCH) ||\
> > + defined(CONFIG_KPROBES)
> > +#define PAGE_KERNEL_TEXT PAGE_KERNEL_X
> > +#else
> > +#define PAGE_KERNEL_TEXT PAGE_KERNEL_ROX
> > +#endif
>
> What about FTRACE? ∞TRACE etc.
Well, I'm just moving those bits around from pgtable-ppc32.h (ie, only
ppc32 uses PAGE_KERNEL_TEXT for now anyway).
Note also that as it is, with ppc32 hash, we don't honor the read-only
restriction on the BAT mapping anyway.
So yes, there's room for fixing things but that isn't what this patch
does.
Cheers,
Ben.
prev parent reply other threads:[~2009-03-02 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 6:22 [PATCH] powerpc/mm: Merge various PTE bits and accessors definitions Benjamin Herrenschmidt
2009-03-02 6:27 ` Benjamin Herrenschmidt
2009-03-02 7:38 ` Michael Ellerman
2009-03-02 7:57 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235980672.7248.4.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).