From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andy Grover <andy.grover@oracle.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, david@gibson.dropbear.id.au
Subject: Re: ext2_* in bitops.h
Date: Wed, 04 Mar 2009 16:58:03 +1100 [thread overview]
Message-ID: <1236146283.6696.36.camel@pasglop> (raw)
In-Reply-To: <49AE114C.6070903@oracle.com>
On Tue, 2009-03-03 at 21:27 -0800, Andy Grover wrote:
> Hi,
>
> Can the ext2_* definitions in arch/powerpc/include/asm/bitops.h be
> replaced with:
>
> #include <include/asm-generic/bitops/ext2-non-atomic.h>
> #include <include/asm-generic/bitops/ext2-atomic.h>
>
> ?
>
> Also, can the bitop swizzling (starting at line 351) be removed by
> including include/asm-generic/bitops/le.h? It looks very similar if not
> identical.
>
> I'm afraid I don't have a ppc to test on so I wanted to see what you all
> thought.
I suppose you are right, I'll have a closer look.
Cheers,
Ben.
prev parent reply other threads:[~2009-03-04 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 5:27 ext2_* in bitops.h Andy Grover
2009-03-04 5:58 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236146283.6696.36.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=andy.grover@oracle.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).