From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/pseries failed reconfig notifier chain call cleanup
Date: Wed, 11 Mar 2009 16:47:47 +1100 [thread overview]
Message-ID: <1236750467.7086.42.camel@pasglop> (raw)
In-Reply-To: <49B02DB5.7020301@austin.ibm.com>
On Thu, 2009-03-05 at 13:53 -0600, Nathan Fontenot wrote:
> The return code from invoking the notifier chain when updating the
> ibm,dynamic-memory property is not handled properly. In failure
> cases (rc == NOTIFY_BAD) we should be restoring the original value
> of the property. In success (rc == NOTIFY_OK) we should be returning
> zero from the calling routine.
This is actually not clear to me ... if the memory has been added or
removed, we must make sure the device-tree is up to date... ie, we can't
tell the firmware that we failed can we ?
Ben.
> Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
> ---
> arch/powerpc/platforms/pseries/reconfig.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/arch/powerpc/platforms/pseries/reconfig.c
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/platforms/pseries/reconfig.c 2008-10-23 22:29:24.000000000 -0500
> +++ linux-2.6/arch/powerpc/platforms/pseries/reconfig.c 2009-03-05 13:20:00.000000000 -0600
> @@ -468,9 +468,13 @@
>
> rc = blocking_notifier_call_chain(&pSeries_reconfig_chain,
> action, value);
> + if (rc == NOTIFY_BAD) {
> + rc = prom_update_property(np, oldprop, newprop);
> + return -ENOMEM;
> + }
> }
>
> - return rc;
> + return 0;
> }
>
> /**
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2009-03-11 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 19:53 [PATCH] powerpc/pseries failed reconfig notifier chain call cleanup Nathan Fontenot
2009-03-11 5:47 ` Benjamin Herrenschmidt [this message]
2009-03-11 15:14 ` Nathan Fontenot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236750467.7086.42.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nfont@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).