linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Piotr Ziecik <kosmo@semihalf.com>
To: LinuxPPC Mailing List <linuxppc-dev@ozlabs.org>
Cc: Piotr Ziecik <kosmo@semihalf.com>
Subject: [PATCH] powerpc: Enable CPU_FTR_NEED_COHERENT for MPC52xx
Date: Mon, 16 Mar 2009 11:05:25 +0100	[thread overview]
Message-ID: <1237197925-71727-1-git-send-email-kosmo@semihalf.com> (raw)
In-Reply-To: <20090311222615.63410@gmx.net>

BestComm, a DMA engine in MPC52xx SoC, requires snooping when
CPU caches are enabled to work properly.

Adding CPU_FTR_NEED_COHERENT fixes NFS problems on MPC52xx machines
introduced by 'powerpc/mm: Fix handling of _PAGE_COHERENT in BAT setup code'.

Signed-off-by: Piotr Ziecik <kosmo@semihalf.com>
---

This patch was succesfully tested on our MPC5200-based.
Ben, Gerhard could you ack this patch, as it implements your suggestion.

 arch/powerpc/include/asm/cputable.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h
index b18358f..22dc2d8 100644
--- a/arch/powerpc/include/asm/cputable.h
+++ b/arch/powerpc/include/asm/cputable.h
@@ -241,9 +241,11 @@ extern const char *powerpc_base_platform;
 /* We need to mark all pages as being coherent if we're SMP or we have a
  * 74[45]x and an MPC107 host bridge. Also 83xx and PowerQUICC II
  * require it for PCI "streaming/prefetch" to work properly.
+ * This is also required by 52xx family.
  */
 #if defined(CONFIG_SMP) || defined(CONFIG_MPC10X_BRIDGE) \
-	|| defined(CONFIG_PPC_83xx) || defined(CONFIG_8260)
+	|| defined(CONFIG_PPC_83xx) || defined(CONFIG_8260) \
+	|| defined(CONFIG_PPC_MPC52xx)
 #define CPU_FTR_COMMON                  CPU_FTR_NEED_COHERENT
 #else
 #define CPU_FTR_COMMON                  0
-- 
1.6.0.6

  reply	other threads:[~2009-03-16 10:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 15:08 NFS problems on a MPC5200-based board Bartłomiej Sięka
2009-03-11 21:39 ` Benjamin Herrenschmidt
2009-03-11 22:26   ` Gerhard Pircher
2009-03-16 10:05     ` Piotr Ziecik [this message]
2009-03-17  3:54       ` [PATCH] powerpc: Enable CPU_FTR_NEED_COHERENT for MPC52xx Grant Likely
2009-03-17  4:43         ` Grant Likely
2009-03-17 12:10           ` Kumar Gala
2009-03-17 13:45             ` Grant Likely
2009-03-17 13:49               ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237197925-71727-1-git-send-email-kosmo@semihalf.com \
    --to=kosmo@semihalf.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).