From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mikhail Zolotaryov <lebon@lebon.org.ua>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc 4xx EMAC driver: device name reported on timeout is not correct
Date: Fri, 20 Mar 2009 16:38:13 +1100 [thread overview]
Message-ID: <1237527493.25062.565.camel@pasglop> (raw)
In-Reply-To: <49B6B240.8030701@lebon.org.ua>
On Tue, 2009-03-10 at 20:32 +0200, Mikhail Zolotaryov wrote:
> Hi,
>
> not critical problem here.
>
> IBM EMAC driver performs device reset (drivers/net/ibm_newemac/core.c:
> emac_probe() -> emac_init_phy() -> emac_reset()) before registering
> appropriate net_device (emac_probe() -> register_netdev()), so
> net_device name contains raw format string during EMAC reset ("eth%d").
>
> If the case of reset timeout, emac_report_timeout_error() function is
> called to report an error. The problem is this function uses net_device
> name to report device related, which is not correct, as a result in the
> kernel log buffer we see:
>
> eth%d: reset timeout
>
> The solution is to print device_node full_name instead. After applying
> the patch proposed, error string is like the following:
>
> /plb/opb/ethernet@ef600e00: reset timeout
>
>
> Signed-off-by: Mikhail Zolotaryov <lebon@lebon.org.ua>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Please submit with my Ack included to the netdev list.
Cheers,
Ben.
>
>
> plain text document attachment (emac_report_timeout_error.patch)
> --- linux-2.6/drivers/net/ibm_newemac/core.c.orig 2009-03-10 20:24:12.000000000 +0200
> +++ linux-2.6/drivers/net/ibm_newemac/core.c 2009-03-10 20:29:12.000000000 +0200
> @@ -134,7 +134,7 @@
> EMAC_FTR_440EP_PHY_CLK_FIX))
> DBG(dev, "%s" NL, error);
> else if (net_ratelimit())
> - printk(KERN_ERR "%s: %s\n", dev->ndev->name, error);
> + printk(KERN_ERR "%s: %s\n", dev->ofdev->node->full_name, error);
> }
>
> /* EMAC PHY clock workaround:
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
prev parent reply other threads:[~2009-03-20 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 18:32 [PATCH] powerpc 4xx EMAC driver: device name reported on timeout is not correct Mikhail Zolotaryov
2009-03-20 5:38 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237527493.25062.565.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=lebon@lebon.org.ua \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).