From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: linuxppc-dev@ozlabs.org, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
systemtap-ml <systemtap@sources.redhat.com>
Subject: Re: [RFC][PATCH -tip 4/9] power: add kernel_trap_sp()
Date: Fri, 20 Mar 2009 16:42:40 +1100 [thread overview]
Message-ID: <1237527760.25062.567.camel@pasglop> (raw)
In-Reply-To: <49C2B4BF.4080904@redhat.com>
On Thu, 2009-03-19 at 17:10 -0400, Masami Hiramatsu wrote:
> Add kernel_trap_sp() on powerpc, based on systemtap's runtime/regs.h.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
I haven't looked at the usage of it, but it's weird to have something
call "kernel_trap_sp" that returns the -user- stack pointer... is
this really what's expected here ?
> ---
> arch/powerpc/include/asm/ptrace.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/ptrace.h b/arch/powerpc/include/asm/ptrace.h
> index c9c678f..0ac366c 100644
> --- a/arch/powerpc/include/asm/ptrace.h
> +++ b/arch/powerpc/include/asm/ptrace.h
> @@ -83,6 +83,7 @@ struct pt_regs {
>
> #define instruction_pointer(regs) ((regs)->nip)
> #define user_stack_pointer(regs) ((regs)->gpr[1])
> +#define kernel_trap_sp(regs) (user_stack_pointer(regs))
> #define regs_return_value(regs) ((regs)->gpr[3])
>
> #ifdef CONFIG_SMP
next prev parent reply other threads:[~2009-03-20 5:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 21:10 [RFC][PATCH -tip 4/9] power: add kernel_trap_sp() Masami Hiramatsu
2009-03-20 5:42 ` Benjamin Herrenschmidt [this message]
2009-03-20 7:33 ` Ananth N Mavinakayanahalli
2009-03-20 10:53 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237527760.25062.567.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).