linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: LinuxPPC Mailing List <linuxppc-dev@ozlabs.org>
Subject: Re: CONFIG_DEBUG_PAGEALLOC generates WARN_ON() in ppc32 hash
Date: Sat, 28 Mar 2009 10:05:57 +1100	[thread overview]
Message-ID: <1238195157.20197.81.camel@pasglop> (raw)
In-Reply-To: <765C1EA1-93F7-4FEF-930B-78E2B3DEB4FA@kernel.crashing.org>

On Fri, 2009-03-27 at 06:56 -0500, Kumar Gala wrote:
> Ben,
> 
> If we have CONFIG_DEBUG_PAGEALLOC enabled we end up hitting the  
> WARN_ON() in set_pte_at() when we boot.  This appears because we've  
> already setup pte's via mapin_ram() after which we end up calling  
> kernel_map_pages().
> 
> So I'm not sure if __change_page_attr() should be doing something  
> different or if the WARN_ON() should be conditional on ! 
> CONFIG_DEBUG_PAGEALLOC

Or use __set_pte_at() ?

Note that C_D_P doesn't work on hash32 anyway...

Ben.

  reply	other threads:[~2009-03-27 23:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-27 11:56 CONFIG_DEBUG_PAGEALLOC generates WARN_ON() in ppc32 hash Kumar Gala
2009-03-27 23:05 ` Benjamin Herrenschmidt [this message]
2009-03-28 16:21   ` Kumar Gala
2009-03-28 21:25     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1238195157.20197.81.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).