From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Cell Broadband Engine OSS Development <cbe-oss-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI
Date: Wed, 01 Apr 2009 20:54:12 +1100 [thread overview]
Message-ID: <1238579652.17330.124.camel@pasglop> (raw)
In-Reply-To: <alpine.LRH.2.00.0904011141550.13419@vixen.sonytel.be>
On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote:
> PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI,
> causing build failures if PCI is not set.
Maybe it should only select it if PCI is enabled ? Is qpace using PCI ?
Cheers,
Ben.
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
> arch/powerpc/platforms/cell/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
> index 40e24c3..33f534f 100644
> --- a/arch/powerpc/platforms/cell/Kconfig
> +++ b/arch/powerpc/platforms/cell/Kconfig
> @@ -14,6 +14,7 @@ config PPC_CELL_NATIVE
> bool
> select PPC_CELL_COMMON
> select PPC_OF_PLATFORM_PCI
> + select PCI
> select MPIC
> select IBM_NEW_EMAC_EMAC4
> select IBM_NEW_EMAC_RGMII
next prev parent reply other threads:[~2009-04-01 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 9:42 [PATCH] powerpc: PPC_CELL_NATIVE should select PCI Geert Uytterhoeven
2009-04-01 9:54 ` Benjamin Herrenschmidt [this message]
2009-04-01 10:45 ` Arnd Bergmann
2009-04-01 11:02 ` Benjamin Herrenschmidt
2009-04-01 12:11 ` Arnd Bergmann
2009-04-02 7:34 ` Geert Uytterhoeven
2009-04-02 13:15 ` Arnd Bergmann
2009-04-02 13:58 ` Benjamin Krill
2009-04-06 6:11 ` Paul Mackerras
2009-04-06 7:34 ` [Cbe-oss-dev] " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238579652.17330.124.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).