* [PATCH] powerpc: PPC_CELL_NATIVE should select PCI @ 2009-04-01 9:42 Geert Uytterhoeven 2009-04-01 9:54 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 10+ messages in thread From: Geert Uytterhoeven @ 2009-04-01 9:42 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: Linux/PPC Development, Cell Broadband Engine OSS Development PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, causing build failures if PCI is not set. Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> --- arch/powerpc/platforms/cell/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig index 40e24c3..33f534f 100644 --- a/arch/powerpc/platforms/cell/Kconfig +++ b/arch/powerpc/platforms/cell/Kconfig @@ -14,6 +14,7 @@ config PPC_CELL_NATIVE bool select PPC_CELL_COMMON select PPC_OF_PLATFORM_PCI + select PCI select MPIC select IBM_NEW_EMAC_EMAC4 select IBM_NEW_EMAC_RGMII -- 1.6.0.4 With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-01 9:42 [PATCH] powerpc: PPC_CELL_NATIVE should select PCI Geert Uytterhoeven @ 2009-04-01 9:54 ` Benjamin Herrenschmidt 2009-04-01 10:45 ` Arnd Bergmann 0 siblings, 1 reply; 10+ messages in thread From: Benjamin Herrenschmidt @ 2009-04-01 9:54 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linux/PPC Development, Cell Broadband Engine OSS Development On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, > causing build failures if PCI is not set. Maybe it should only select it if PCI is enabled ? Is qpace using PCI ? Cheers, Ben. > Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> > --- > arch/powerpc/platforms/cell/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig > index 40e24c3..33f534f 100644 > --- a/arch/powerpc/platforms/cell/Kconfig > +++ b/arch/powerpc/platforms/cell/Kconfig > @@ -14,6 +14,7 @@ config PPC_CELL_NATIVE > bool > select PPC_CELL_COMMON > select PPC_OF_PLATFORM_PCI > + select PCI > select MPIC > select IBM_NEW_EMAC_EMAC4 > select IBM_NEW_EMAC_RGMII ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-01 9:54 ` Benjamin Herrenschmidt @ 2009-04-01 10:45 ` Arnd Bergmann 2009-04-01 11:02 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 10+ messages in thread From: Arnd Bergmann @ 2009-04-01 10:45 UTC (permalink / raw) To: linuxppc-dev; +Cc: Geert Uytterhoeven, Cell Broadband Engine OSS Development On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, > > causing build failures if PCI is not set. > > Maybe it should only select it if PCI is enabled ? Is qpace using PCI ? No, QPACE does not have any PCI devices whatsoever. Arnd <>< ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-01 10:45 ` Arnd Bergmann @ 2009-04-01 11:02 ` Benjamin Herrenschmidt 2009-04-01 12:11 ` Arnd Bergmann 2009-04-02 7:34 ` Geert Uytterhoeven 0 siblings, 2 replies; 10+ messages in thread From: Benjamin Herrenschmidt @ 2009-04-01 11:02 UTC (permalink / raw) To: Arnd Bergmann Cc: Geert Uytterhoeven, linuxppc-dev, Cell Broadband Engine OSS Development On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote: > On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > > On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > > > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, > > > causing build failures if PCI is not set. > > > > Maybe it should only select it if PCI is enabled ? Is qpace using PCI ? > > No, QPACE does not have any PCI devices whatsoever. so something like select PPC_OF_PLATFORM_PCI if PCI would work you think ? Ben. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-01 11:02 ` Benjamin Herrenschmidt @ 2009-04-01 12:11 ` Arnd Bergmann 2009-04-02 7:34 ` Geert Uytterhoeven 1 sibling, 0 replies; 10+ messages in thread From: Arnd Bergmann @ 2009-04-01 12:11 UTC (permalink / raw) To: linuxppc-dev; +Cc: Geert Uytterhoeven, Cell Broadband Engine OSS Development On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote: > > No, QPACE does not have any PCI devices whatsoever. > > so something like select PPC_OF_PLATFORM_PCI if PCI would work you > think ? Yes, that sounds good. Arnd <>< ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-01 11:02 ` Benjamin Herrenschmidt 2009-04-01 12:11 ` Arnd Bergmann @ 2009-04-02 7:34 ` Geert Uytterhoeven 2009-04-02 13:15 ` Arnd Bergmann 1 sibling, 1 reply; 10+ messages in thread From: Geert Uytterhoeven @ 2009-04-02 7:34 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: linuxppc-dev, Cell Broadband Engine OSS Development, Arnd Bergmann On Wed, 1 Apr 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote: > > On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote: > > > On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote: > > > > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI, > > > > causing build failures if PCI is not set. > > > > > > Maybe it should only select it if PCI is enabled ? Is qpace using PCI ? > > > > No, QPACE does not have any PCI devices whatsoever. > > so something like select PPC_OF_PLATFORM_PCI if PCI would work you > think ? I gave it a try. Patch below. But that is still not sufficient: | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to `pci_io_base' due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file shouldn't be built when CONFIG_PCI=n? As I don't have the hardware to test anyway, I'll give up. diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig index 40e24c3..fa604b1 100644 --- a/arch/powerpc/platforms/cell/Kconfig +++ b/arch/powerpc/platforms/cell/Kconfig @@ -13,7 +13,7 @@ config PPC_CELL_COMMON config PPC_CELL_NATIVE bool select PPC_CELL_COMMON - select PPC_OF_PLATFORM_PCI + select PPC_OF_PLATFORM_PCI if PCI select MPIC select IBM_NEW_EMAC_EMAC4 select IBM_NEW_EMAC_RGMII diff --git a/arch/powerpc/platforms/cell/setup.c b/arch/powerpc/platforms/cell/setup.c index 5930536..628b21f 100644 --- a/arch/powerpc/platforms/cell/setup.c +++ b/arch/powerpc/platforms/cell/setup.c @@ -81,6 +81,7 @@ static void cell_progress(char *s, unsigned short hex) printk("*** %04x : %s\n", hex, s ? s : ""); } +#ifdef CONFIG_PCI static void cell_fixup_pcie_rootcomplex(struct pci_dev *dev) { struct pci_controller *hose; @@ -141,6 +142,7 @@ static int __devinit cell_setup_phb(struct pci_controller *phb) return 0; } +#endif /* CONFIG_PCI */ static int __init cell_publish_devices(void) { @@ -287,5 +289,7 @@ define_machine(cell) { .calibrate_decr = generic_calibrate_decr, .progress = cell_progress, .init_IRQ = cell_init_irq, +#ifdef CONFIG_PCI .pci_setup_phb = cell_setup_phb, +#endif }; With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-02 7:34 ` Geert Uytterhoeven @ 2009-04-02 13:15 ` Arnd Bergmann 2009-04-02 13:58 ` Benjamin Krill 2009-04-06 6:11 ` Paul Mackerras 0 siblings, 2 replies; 10+ messages in thread From: Arnd Bergmann @ 2009-04-02 13:15 UTC (permalink / raw) To: linuxppc-dev; +Cc: Geert Uytterhoeven, Cell Broadband Engine OSS Development On Thursday 02 April 2009, Geert Uytterhoeven wrote: > | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to `pci_io_base' > > due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file > shouldn't be built when CONFIG_PCI=n? Right, the I/O workarounds are specific to the spider PCI implementation, so there is no point in having them without PCI support. > As I don't have the hardware to test anyway, I'll give up. BenK, can you try Geert's patch on QPACE? Arnd <>< ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-02 13:15 ` Arnd Bergmann @ 2009-04-02 13:58 ` Benjamin Krill 2009-04-06 6:11 ` Paul Mackerras 1 sibling, 0 replies; 10+ messages in thread From: Benjamin Krill @ 2009-04-02 13:58 UTC (permalink / raw) To: Arnd Bergmann Cc: Geert Uytterhoeven, linuxppc-dev, Cell Broadband Engine OSS Development * Arnd Bergmann | 2009-04-02 15:15:11 [+0200]: >BenK, can you try Geert's patch on QPACE? Successfully tested on QPACE. Acked-by: Benjamin Krill <ben@codiert.org> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-02 13:15 ` Arnd Bergmann 2009-04-02 13:58 ` Benjamin Krill @ 2009-04-06 6:11 ` Paul Mackerras 2009-04-06 7:34 ` [Cbe-oss-dev] " Geert Uytterhoeven 1 sibling, 1 reply; 10+ messages in thread From: Paul Mackerras @ 2009-04-06 6:11 UTC (permalink / raw) To: Arnd Bergmann Cc: Geert Uytterhoeven, linuxppc-dev, Cell Broadband Engine OSS Development Arnd Bergmann writes: > On Thursday 02 April 2009, Geert Uytterhoeven wrote: > > | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to `pci_io_base' > > > > due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file > > shouldn't be built when CONFIG_PCI=n? > > Right, the I/O workarounds are specific to the spider PCI implementation, > so there is no point in having them without PCI support. > > > As I don't have the hardware to test anyway, I'll give up. > > BenK, can you try Geert's patch on QPACE? So is that patch good or not? If it's good, could someone please repost it with a proper patch description etc.? Thanks, Paul. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Cbe-oss-dev] [PATCH] powerpc: PPC_CELL_NATIVE should select PCI 2009-04-06 6:11 ` Paul Mackerras @ 2009-04-06 7:34 ` Geert Uytterhoeven 0 siblings, 0 replies; 10+ messages in thread From: Geert Uytterhoeven @ 2009-04-06 7:34 UTC (permalink / raw) To: Paul Mackerras Cc: linuxppc-dev, Cell Broadband Engine OSS Development, Arnd Bergmann On Mon, 6 Apr 2009, Paul Mackerras wrote: > Arnd Bergmann writes: > > On Thursday 02 April 2009, Geert Uytterhoeven wrote: > > > | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to `pci_io_base' > > > > > > due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file > > > shouldn't be built when CONFIG_PCI=n? > > > > Right, the I/O workarounds are specific to the spider PCI implementation, > > so there is no point in having them without PCI support. > > > > > As I don't have the hardware to test anyway, I'll give up. > > > > BenK, can you try Geert's patch on QPACE? > > So is that patch good or not? If it's good, could someone please > repost it with a proper patch description etc.? It's not good, as it still causes the link error above. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-04-06 7:34 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-04-01 9:42 [PATCH] powerpc: PPC_CELL_NATIVE should select PCI Geert Uytterhoeven 2009-04-01 9:54 ` Benjamin Herrenschmidt 2009-04-01 10:45 ` Arnd Bergmann 2009-04-01 11:02 ` Benjamin Herrenschmidt 2009-04-01 12:11 ` Arnd Bergmann 2009-04-02 7:34 ` Geert Uytterhoeven 2009-04-02 13:15 ` Arnd Bergmann 2009-04-02 13:58 ` Benjamin Krill 2009-04-06 6:11 ` Paul Mackerras 2009-04-06 7:34 ` [Cbe-oss-dev] " Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).