From: tiejun.china@gmail.com
To: linuxppc-dev@ozlabs.org, benh@kernel.crashing.org,
akpm@linux-foundation.org, michael@ellerman.id.au
Subject: [v1 PATCH 1/1] Fix 64bit Maple Host Bridge Address and Size Nodes
Date: Fri, 3 Apr 2009 18:46:34 +0800 [thread overview]
Message-ID: <1238755594-18869-2-git-send-email-tiejun.china@gmail.com> (raw)
In-Reply-To: <1238755594-18869-1-git-send-email-tiejun.china@gmail.com>
In the DTB tree created by firmware on some Maple 64bit targets, such as ATCA6101,
these two properties, address&size, should be 2. But the actual corresponding values
of host bridge node are set 1 incorrectly by the firmware, we have to provide one
fixup function to fix that.
Signed-off-by: Tiejun Chen <tiejun.china@gmail.com>
---
arch/powerpc/kernel/prom_init.c | 51 ++++++++++++++++++++++++++++++++++++++-
1 files changed, 50 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 2445945..7848b45 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -1907,14 +1907,63 @@ static void __init flatten_device_tree(void)
}
#ifdef CONFIG_PPC_MAPLE
+/* On ATCA6101 64bit target host bridge parent node has specified address and
+ * size properties to be 2. But the actual "cell" value for host bridge node
+ * is 1 since early MOTLoad internal bug. */
+static void __init fixup_device_tree_atca6101(void)
+{
+ phandle hb;
+ u32 hb_ranges[4];
+ u32 size_cell, addr_cell;
+ struct prom_t *_prom = &RELOC(prom);
+ char *name;
+
+ name = "/hostbridge@f8000000";
+ hb = call_prom("finddevice", 1, 1, ADDR(name));
+ if (!PHANDLE_VALID(hb))
+ return;
+
+ if (prom_getproplen(hb, "reg") != 8)
+ return;
+
+ if (prom_getprop(hb, "reg", hb_ranges, (sizeof(hb_ranges))/2)
+ == PROM_ERROR)
+ return;
+
+ prom_getprop(_prom->root, "#address-cells", &addr_cell, sizeof(addr_cell));
+ prom_getprop(_prom->root, "#size-cells", &size_cell, sizeof(size_cell));
+
+ if ((addr_cell != 2) || (size_cell != 2) ||
+ (hb_ranges[0] != 0xf8000000))
+ return;
+
+ prom_printf("Fixing up bogus HOSTBRIDGE reg on ATCA6101...\n");
+
+ hb_ranges[3] = hb_ranges[1];
+ hb_ranges[1] = hb_ranges[0];
+ hb_ranges[0] = hb_ranges[2] = 0;
+ prom_setprop(hb, name, "reg",
+ hb_ranges, sizeof(hb_ranges));
+}
/* PIBS Version 1.05.0000 04/26/2005 has an incorrect /ht/isa/ranges property.
- * The values are bad, and it doesn't even have the right number of cells. */
+ * The values are bad, and it doesn't even have the right number of cells.
+ * Additionally, the early MOTLoad generate incorrect address&size cells on
+ * some Maple platform such as ATCA6101. */
static void __init fixup_device_tree_maple(void)
{
phandle isa;
u32 rloc = 0x01002000; /* IO space; PCI device = 4 */
u32 isa_ranges[6];
char *name;
+ u32 node;
+ char prop[64];
+ int model;
+
+ /* FIXME: This may be used for more Maple targets not only ATCA6101. */
+ node = call_prom("finddevice", 1, 1, ADDR("/"));
+ model = prom_getprop(node, "model", prop, sizeof(prop));
+ if (model != PROM_ERROR && (strcmp(prop, "Motorola,ATCA-6101") == 0))
+ fixup_device_tree_atca6101();
name = "/ht@0/isa@4";
isa = call_prom("finddevice", 1, 1, ADDR(name));
--
1.5.6
next prev parent reply other threads:[~2009-04-03 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 10:46 [PATCH 1/1] Fix 64bit Mapple Host Bridge Address and Size Nodes tiejun.china
2009-04-03 10:46 ` tiejun.china [this message]
2009-04-14 8:11 ` [v1 PATCH 1/1] Fix 64bit Maple " Segher Boessenkool
2009-04-14 10:11 ` Tiejun Chen
[not found] <49E2A2D2.2000606@windriver.com>
2009-04-13 2:27 ` Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238755594-18869-2-git-send-email-tiejun.china@gmail.com \
--to=tiejun.china@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).