[PATCH] powerpc/oprofile: dump_pmcs() is not used

[PATCH] powerpc/oprofile: dump_pmcs() is not used

[Michael Ellerman]

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/oprofile/op_model_fsl_emb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Or should we just remove it?

diff --git a/arch/powerpc/oprofile/op_model_fsl_emb.c b/arch/powerpc/oprofile/op_model_fsl_emb.c
index 91596f6..4abd466 100644
--- a/arch/powerpc/oprofile/op_model_fsl_emb.c
+++ b/arch/powerpc/oprofile/op_model_fsl_emb.c
@@ -228,6 +228,7 @@ static void pmc_stop_ctrs(void)
 	mtpmr(PMRN_PMGC0, pmgc0);
 }
 
+#if 0
 static void dump_pmcs(void)
 {
 	printk("pmgc0: %x\n", mfpmr(PMRN_PMGC0));
@@ -241,6 +242,7 @@ static void dump_pmcs(void)
 	printk("%8x\t%8x\t%8x\n", mfpmr(PMRN_PMC3),
 			mfpmr(PMRN_PMLCA3), mfpmr(PMRN_PMLCB3));
 }
+#endif
 
 static int fsl_emb_cpu_setup(struct op_counter_config *ctr)
 {
-- 
1.6.2.1

Re: [PATCH] powerpc/oprofile: dump_pmcs() is not used

[Kumar Gala]

On Apr 6, 2009, at 8:45 AM, Michael Ellerman wrote:

> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> ---
> arch/powerpc/oprofile/op_model_fsl_emb.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> Or should we just remove it?

I'm for removing it if Andy doesn't have any issues.  Someone can  
always add it back as debugfs code in the future if they want it.

- k

Re: [PATCH] powerpc/oprofile: dump_pmcs() is not used

[Kumar Gala]

On Apr 6, 2009, at 9:03 AM, Kumar Gala wrote:

>
> On Apr 6, 2009, at 8:45 AM, Michael Ellerman wrote:
>
>> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
>> ---
>> arch/powerpc/oprofile/op_model_fsl_emb.c |    2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> Or should we just remove it?
>
> I'm for removing it if Andy doesn't have any issues.  Someone can  
> always add it back as debugfs code in the future if they want it.

I chatted w/Andy and we both agreed to just remove the code rather  
than #if 0 it.  If you send me a patch with that I'll apply it.

- k

Re: [PATCH] powerpc/oprofile: dump_pmcs() is not used

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

On Tue, 2009-04-07 at 14:42 -0500, Kumar Gala wrote:
> On Apr 6, 2009, at 9:03 AM, Kumar Gala wrote:
> 
> >
> > On Apr 6, 2009, at 8:45 AM, Michael Ellerman wrote:
> >
> >> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> >> ---
> >> arch/powerpc/oprofile/op_model_fsl_emb.c |    2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> Or should we just remove it?
> >
> > I'm for removing it if Andy doesn't have any issues.  Someone can  
> > always add it back as debugfs code in the future if they want it.
> 
> I chatted w/Andy and we both agreed to just remove the code rather  
> than #if 0 it.  If you send me a patch with that I'll apply it.

Cool, done.

Delegated to you in patchwork too. I was going to mark the old one as
superseded but I won't mess with it while it's delegated to you.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]