From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kyle Moffett <kyle@moffetthome.net>
Cc: netdev <netdev@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)
Date: Wed, 22 Apr 2009 10:21:16 +0200 [thread overview]
Message-ID: <1240388476.17445.10.camel@pasglop> (raw)
In-Reply-To: <f73f7ab80904201710m57472291yf7ff86760977b8e8@mail.gmail.com>
On Mon, 2009-04-20 at 20:10 -0400, Kyle Moffett wrote:
> > IIRC, Ben had some issues with how phylib and the EMAC would need to
> > interact. Not sure if he has those written down somewhere or not.
> > (CC'd).
>
> Hmm, yeah, I'd be interested to see those. There's enough similar
> between phylib and the EMAC and sungem drivers that I'm considering a
> series of somewhat-mechanical patches to make EMAC and sungem use the
> "struct phy_device" and "struct mii_bus" from phylib, possibly
> abstracting out some helper functions along the way.
Yup, emac and sungem predate phylib.
I had a quick look at what it would take to port at least emac over, the
main issue was that I want to be able to sleep (ie, take a mutex) in my
mdio read/write functions, and back then, phylib wouldn't let me do that
due to spinlock and timer/softirq usage.
Ben.
next prev parent reply other threads:[~2009-04-27 0:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f73f7ab80904171732n41832d0hc62978e57bbcc32e@mail.gmail.com>
2009-04-20 12:29 ` Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions) Josh Boyer
2009-04-21 0:10 ` Kyle Moffett
2009-04-22 8:21 ` Benjamin Herrenschmidt [this message]
2009-04-30 15:04 ` Kyle Moffett
2009-04-30 15:11 ` Grant Likely
2009-04-30 15:33 ` Kyle Moffett
2009-04-30 21:18 ` Benjamin Herrenschmidt
2009-04-30 22:21 ` Kyle Moffett
2009-05-03 4:26 ` Kyle Moffett
2009-05-03 22:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240388476.17445.10.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=kyle@moffetthome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).