From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3754CDDED5 for ; Mon, 27 Apr 2009 10:11:41 +1000 (EST) Subject: Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions) From: Benjamin Herrenschmidt To: Kyle Moffett In-Reply-To: References: <625fc13d0904200529l152b8d75g33c3f940de1b2920@mail.gmail.com> Content-Type: text/plain Date: Wed, 22 Apr 2009 10:21:16 +0200 Message-Id: <1240388476.17445.10.camel@pasglop> Mime-Version: 1.0 Cc: netdev , "Linux-Kernel@Vger. Kernel. Org" , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2009-04-20 at 20:10 -0400, Kyle Moffett wrote: > > IIRC, Ben had some issues with how phylib and the EMAC would need to > > interact. Not sure if he has those written down somewhere or not. > > (CC'd). > > Hmm, yeah, I'd be interested to see those. There's enough similar > between phylib and the EMAC and sungem drivers that I'm considering a > series of somewhat-mechanical patches to make EMAC and sungem use the > "struct phy_device" and "struct mii_bus" from phylib, possibly > abstracting out some helper functions along the way. Yup, emac and sungem predate phylib. I had a quick look at what it would take to port at least emac over, the main issue was that I want to be able to sleep (ie, take a mutex) in my mdio read/write functions, and back then, phylib wouldn't let me do that due to spinlock and timer/softirq usage. Ben.