From: Michael Ellerman <michael@ellerman.id.au>
To: Li Yang <leoli@freescale.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] rio: warn_unused_result warnings fix
Date: Tue, 28 Apr 2009 20:51:22 +1000 [thread overview]
Message-ID: <1240915882.15414.3.camel@localhost> (raw)
In-Reply-To: <1240913737-23773-5-git-send-email-leoli@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Tue, 2009-04-28 at 18:15 +0800, Li Yang wrote:
> warning: ignoring return value of 'device_add', declared with attribute warn_unused_result
> warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result
>
> Signed-off-by: Li Yang <leoli@freescale.com>
> ---
> drivers/rapidio/rio-scan.c | 5 ++++-
> drivers/rapidio/rio-sysfs.c | 6 ++++--
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
> index 74d0bfa..9309e24 100644
> --- a/drivers/rapidio/rio-scan.c
> +++ b/drivers/rapidio/rio-scan.c
> @@ -265,7 +265,10 @@ static void rio_route_set_ops(struct rio_dev *rdev)
> */
> static void __devinit rio_add_device(struct rio_dev *rdev)
> {
> - device_add(&rdev->dev);
> + int err;
> +
> + err = device_add(&rdev->dev);
> + WARN_ON(err);
>
> spin_lock(&rio_global_list_lock);
> list_add_tail(&rdev->global_list, &rio_devices);
Is that really useful? Why not return the error to rio_setup_device()
which can tell it's caller.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-04-28 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 10:16 [PATCH 0/5] rapidio: adding memory mapping IO support and misc fixes Li Yang
2009-04-28 10:15 ` [PATCH] rapidio: add common mapping APIs for RapidIO memory access Li Yang
2009-04-28 10:15 ` [PATCH] powerpc/fsl_rio: use LAW address from device tree Li Yang
2009-04-28 10:15 ` [PATCH] powerpc: add memory map support to Freescale RapioIO block Li Yang
2009-04-28 10:15 ` [PATCH] rionet: add memory access to simulated Ethernet over rapidio Li Yang
2009-04-28 10:15 ` [PATCH] rio: warn_unused_result warnings fix Li Yang
2009-04-28 10:51 ` Michael Ellerman [this message]
2009-04-28 11:08 ` Li Yang
2009-04-28 11:38 ` David Miller
2009-04-28 11:39 ` [PATCH] rapidio: add common mapping APIs for RapidIO memory access David Miller
2009-04-30 5:10 ` Li Yang
2009-04-30 11:45 ` Kumar Gala
2009-04-28 12:06 ` [PATCH 0/5] rapidio: adding memory mapping IO support and misc fixes Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240915882.15414.3.camel@localhost \
--to=michael@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).