From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Linuxppc-dev Development <linuxppc-dev@ozlabs.org>
Subject: Re: why does ppc64 require boards to call pci_devs_phb_init()?
Date: Fri, 01 May 2009 07:09:14 +1000 [thread overview]
Message-ID: <1241125754.29501.36.camel@pasglop> (raw)
In-Reply-To: <547963B5-28FB-4075-B39A-C99B28554E3F@kernel.crashing.org>
On Thu, 2009-04-30 at 13:04 -0500, Kumar Gala wrote:
> On Apr 30, 2009, at 10:37 AM, Kumar Gala wrote:
>
> > looking at merging this in w/ppc32 and wondering why board code has
> > to call pci_devs_phb_init() and not do it via pcibios_init()
> >
> > - k
>
> As I look at this a bit more, I'm thinking why don't we do:
>
> pci_devs_phb_init_dynamic() in pcibios_alloc_controller
>
> An add some code into pci_devs_phb_init_dynamic so we don't re-do
> update_dn_pci_info if dn->data is already set.
>
> I am not sure what impact this has ppc64 systems that call
> pci_devs_phb_init()
That would probably work, remains the reconfig notifier thing but that
can probably be moved to pseries platform.
Cheers,
Ben.
next prev parent reply other threads:[~2009-04-30 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 15:37 why does ppc64 require boards to call pci_devs_phb_init()? Kumar Gala
2009-04-30 18:04 ` Kumar Gala
2009-04-30 21:09 ` Benjamin Herrenschmidt [this message]
2009-04-30 21:08 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241125754.29501.36.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).