From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benh@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTPS id 82B32DDE1D
	for <linuxppc-dev@ozlabs.org>; Fri,  1 May 2009 07:09:26 +1000 (EST)
Subject: Re: why does ppc64 require boards to call pci_devs_phb_init()?
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
In-Reply-To: <547963B5-28FB-4075-B39A-C99B28554E3F@kernel.crashing.org>
References: <33403DE1-6AC2-49E9-9539-C520E4944D77@kernel.crashing.org>
	<547963B5-28FB-4075-B39A-C99B28554E3F@kernel.crashing.org>
Content-Type: text/plain
Date: Fri, 01 May 2009 07:09:14 +1000
Message-Id: <1241125754.29501.36.camel@pasglop>
Mime-Version: 1.0
Cc: Linuxppc-dev Development <linuxppc-dev@ozlabs.org>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Thu, 2009-04-30 at 13:04 -0500, Kumar Gala wrote:
> On Apr 30, 2009, at 10:37 AM, Kumar Gala wrote:
> 
> > looking at merging this in w/ppc32 and wondering why board code has  
> > to call pci_devs_phb_init() and not do it via pcibios_init()
> >
> > - k
> 
> As I look at this a bit more, I'm thinking why don't we do:
> 
> pci_devs_phb_init_dynamic() in pcibios_alloc_controller
> 
> An add some code into pci_devs_phb_init_dynamic so we don't re-do  
> update_dn_pci_info if dn->data is already set.
> 
> I am not sure what impact this has ppc64 systems that call  
> pci_devs_phb_init()

That would probably work, remains the reconfig notifier thing but that
can probably be moved to pseries platform.

Cheers,
Ben.