linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: linuxppc-dev@ozlabs.org
Cc: Wolfgang Denk <wd@denx.de>
Subject: [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue ***
Date: Wed,  6 May 2009 22:21:02 +0200	[thread overview]
Message-ID: <1241641262-5202-6-git-send-email-wd@denx.de> (raw)
In-Reply-To: <1241641262-5202-1-git-send-email-wd@denx.de>

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: John Rigby <jcrigby@gmail.com>
---
This patch is NOT intended for inclusion into mainline, but rather a
request for help. For some reason which I don't understand yet, the
Ethernet interface on the ARIA board does not work in the default
configuration, because MII probing fails.

What I'm seeing is this; the problem is with this part of code in
"drivers/net/fs_enet/mii-fec.c":

156         fec->mii_speed = ((ppc_proc_freq + 4999999) / 5000000) << 1;
...
163         out_be32(&fec->fecp->fec_mii_speed, fec->mii_speed);

I added some debug messages, and this is what I see:

On the ADS5121, we have the CPU clocked at 400 MHz.  I get:
...
## ppc_proc_freq = 399999996, fec->mii_speed = 160
FEC MII Bus: probed
...
It works fine.

According to the Ref. Man.:
        A value of 0 in this field turns off the MDC and leaves it in
        a low-voltage state. Any non-zero value results in the MDC
        frequency of 1/(mii_speed*2) of the system clock frequency.
that means we have a MDC frequency of
	400 MHz / (2 * 160) = 1.25 MHz
which is obviously within the 2.5 MHz limit.

Now ARIA is currently running at 316.8 MHz, and this is what I get:
...
## ppc_proc_freq = 316800000, fec->mii_speed = 128
fsl-fec-mdio: probe of 80002800.mdio failed with error -5
...
It fails. MDC frequency is
	316.8 MHz / (2 * 128) = 1.24 MHz
which should be fine.

However, If I change the code to

fec->mii_speed = (((ppc_proc_freq / 1000000) / 30) + 1) << 1;

then I get:
...
## ppc_proc_freq = 316800000, fec->mii_speed = 22
FEC MII Bus: probed
... and it's working!!! However, I compute MDC frequency as
	316.8 MHz / (2 * 22) = 7.2 MHz
which is far above the maximum allowed clock of 2.5 MHz ???

Has anybody any idea what might be going on here?


 drivers/net/fs_enet/mii-fec.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
index 9d8bd97..a51dd83 100644
--- a/drivers/net/fs_enet/mii-fec.c
+++ b/drivers/net/fs_enet/mii-fec.c
@@ -153,8 +153,12 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
 	if (!fec->fecp)
 		goto out_fec;
 
+#if 0
 	fec->mii_speed = ((ppc_proc_freq + 4999999) / 5000000) << 1;
-
+#else
+	fec->mii_speed = (((ppc_proc_freq / 1000000) / 30) + 1) << 1;
+	printk("## ppc_proc_freq = %d, fec->mii_speed = %d\n", ppc_proc_freq, fec->mii_speed);
+#endif
 	setbits32(&fec->fecp->fec_r_cntrl, FEC_RCNTRL_MII_MODE);
 	setbits32(&fec->fecp->fec_ecntrl, FEC_ECNTRL_PINMUX |
 	                                  FEC_ECNTRL_ETHER_EN);
-- 
1.6.0.6

  parent reply	other threads:[~2009-05-06 20:21 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 20:20 [PATCH 00/04] Add support for ARIA board Wolfgang Denk
2009-05-06 20:20 ` [PATCH 01/04] mpc5121: prepare support for additional boards Wolfgang Denk
2009-05-06 20:29   ` Grant Likely
2009-05-06 20:40     ` Wolfgang Denk
2009-05-06 21:11       ` Grant Likely
2009-05-06 20:20 ` [PATCH 02/04] ARIA: add device tree source file Wolfgang Denk
2009-05-06 20:21 ` [PATCH 03/04] mpc5121: add support for ARIA board Wolfgang Denk
2009-05-06 20:21 ` [PATCH 04/04] ARIA: add default config file Wolfgang Denk
2009-05-06 20:21 ` Wolfgang Denk [this message]
2009-05-07  8:26   ` [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue *** Joakim Tjernlund
2009-05-07  9:19     ` Wolfgang Denk
2009-05-07  9:30       ` Joakim Tjernlund
2009-05-08  2:09   ` John Rigby
2009-06-06 22:16     ` Wolfgang Denk
2009-06-06 22:27       ` John Rigby
2009-06-06 23:21         ` Wolfgang Denk
2009-06-07  0:08           ` John Rigby
2009-06-07  8:20             ` Wolfram Sang
2009-06-07 20:34             ` Wolfgang Denk
2009-06-08  7:46               ` Wolfgang Grandegger
2009-06-08  8:19                 ` Wolfgang Denk
2009-06-08 14:39                   ` Grant Likely
2009-06-08 14:37               ` Grant Likely
2009-06-11 20:19                 ` [PATCH] mpc5xxx_get_bus_frequency(): use common code on MPC512x and MPC52xx Wolfgang Denk
2009-06-17  6:14                   ` Grant Likely
2009-06-17  6:21                     ` Grant Likely
2009-06-11 20:19                 ` [PATCH RFC] fs_enet/mii-fec.c: fix MII speed calculation Wolfgang Denk
2009-07-14 13:42                   ` [PATCH v2] " Wolfgang Denk
2009-07-15 15:18                     ` [PATCH 1/2 v3] " Wolfgang Denk
2009-07-15 17:17                       ` Grant Likely
2009-07-16 21:21                         ` Wolfgang Denk
2009-07-16 22:37                           ` Grant Likely
2009-07-16 21:42                       ` [PATCH 1/2 v4] " Wolfgang Denk
2009-07-16 22:44                         ` Grant Likely
2009-07-17 12:24                           ` Wolfgang Denk
2009-07-17  9:33                         ` Wolfram Sang
2009-07-17 12:32                           ` Wolfgang Denk
2009-07-17 12:27                         ` [PATCH 1/2 v5] " Wolfgang Denk
2009-07-17 14:41                           ` Grant Likely
2009-07-17 16:21                             ` David Miller
2009-07-17 16:48                             ` David Miller
2009-07-17 12:27                         ` [PATCH 2/2 v3] MPC52xx FEC: be more conservative when setting MII_SPEED register Wolfgang Denk
2009-07-17 12:59                           ` [PATCH 2/2 v4] " Wolfgang Denk
2009-07-17 14:45                             ` Grant Likely
2009-07-17 17:51                               ` Wolfgang Denk
2009-07-17 18:31                                 ` Grant Likely
2009-07-16 21:42                       ` [PATCH 2/2 v2] " Wolfgang Denk
2009-07-16 22:48                         ` Grant Likely
2009-07-17 12:25                           ` Wolfgang Denk
2009-07-17  9:47                         ` Wolfram Sang
2009-07-17 12:35                           ` Wolfgang Denk
2009-07-15 15:18                     ` [PATCH 2/2] " Wolfgang Denk
2009-07-15 17:18                       ` Grant Likely
2009-07-16 21:21                         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241641262-5202-6-git-send-email-wd@denx.de \
    --to=wd@denx.de \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).