linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH v3] powerpc: Keep track of emulated instructions if debugfs is enabled
Date: Mon, 11 May 2009 12:32:41 +1000	[thread overview]
Message-ID: <1242009161.7767.38.camel@concordia> (raw)
In-Reply-To: <alpine.LRH.2.00.0905081611130.7964@vixen.sonytel.be>

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Fri, 2009-05-08 at 16:15 +0200, Geert Uytterhoeven wrote:
> Counters for the various classes of emulated instructions are available under
> /sys/kernel/debug/powerpc/emulated_instructions (assumed debugfs is mounted on
> /sys/kernel/debug).  Optionally (controlled by
> /sys/kernel/debug/powerpc/emulated_instructions/do_warn), rate-limited warnings
> can be printed to the console when instructions are emulated.
> 
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
> Tested on ppc64 (ps3) and ppc32 (sequoia) using mfpvr.
> 
> v3:
>   - add generic unaligned
>   - switch from sysfs + sysctl to debugfs. All virtual files now show up under
>     /sys/kernel/debug/powerpc/emulated_instructions (assumed debugfs mounted on
>     /sys/kernel/debug)
>   - enable the printing of rate-limited warnings by writing a non-zero value to
>     /sys/kernel/debug/powerpc/emulated_instructions/do_warn
>   - switch from per-CPU to system-wide counters
>   - always use 32-bit counters (was 64-bit on ppc64)
>   - counters are writable, i.e. can be reset (by root)

Nice :)

My only query is whether it needs its own CONFIG option. Some folks
might want other DEBUG_FS things but not this?

cheers


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-05-11  2:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08 14:15 [PATCH v3] powerpc: Keep track of emulated instructions if debugfs is enabled Geert Uytterhoeven
2009-05-11  2:32 ` Michael Ellerman [this message]
2009-05-11  6:39   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242009161.7767.38.camel@concordia \
    --to=michael@ellerman.id.au \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).