linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gabriel Paubert <paubert@iram.es>
Cc: LinuxPPC <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again
Date: Mon, 18 May 2009 13:24:49 +1000	[thread overview]
Message-ID: <1242617089.18075.25.camel@pasglop> (raw)
In-Reply-To: <20090515181813.GA28132@iram.es>

On Fri, 2009-05-15 at 20:18 +0200, Gabriel Paubert wrote:
> Since PPC_MUTIPLATFORM was removed, it was impossible to select the
> driver for mv643xx_eth on the Pegasos. Fix by allowing to select
> the driver on CHRP platforms; Pegasos is a CHRP platform and the driver
> will not work wihtout arch/powerpc/platforms/chrp/pegasos_eth.
> 
> The patch also removes all references to MV64360 config option which 
> no more exists.
> 
> Signed-off-by: Gabriel Paubert <paubert@iram.es> 

Please break that up into 2 different patches. The arch/powerpc one that
removes the reference from IRQ_ALL_CPUs and the drivers/net/ one which
should be set to the netdev mailing list.

Thanks !

Cheers,
Ben.

> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index a0d1146..1dfeb62 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -360,7 +360,7 @@ config PPCBUG_NVRAM
>  
>  config IRQ_ALL_CPUS
>  	bool "Distribute interrupts on all CPUs by default"
> -	depends on SMP && !MV64360
> +	depends on SMP 
>  	help
>  	  This option gives the kernel permission to distribute IRQs across
>  	  multiple CPUs.  Saying N here will route all IRQs to the first
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 214a92d..6fc0ff4 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
>  
>  config MV643XX_ETH
>  	tristate "Marvell Discovery (643XX) and Orion ethernet support"
> -	depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) || PLAT_ORION
> +	depends on MV64X60 || PPC_CHRP || PLAT_ORION
>  	select INET_LRO
>  	select PHYLIB
>  	help

  reply	other threads:[~2009-05-18  3:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15 18:18 [PATCH] Allow selecting mv643xx_eth on Pegasos again Gabriel Paubert
2009-05-18  3:24 ` Benjamin Herrenschmidt [this message]
2009-05-18 17:33   ` Gabriel Paubert
  -- strict thread matches above, loose matches on Subject: below --
2009-05-18 17:37 Gabriel Paubert
2009-05-18 17:48 ` Medve Emilian-EMMEDVE1
2009-05-18 18:47   ` Gabriel Paubert
2009-05-18 20:15     ` Medve Emilian-EMMEDVE1
2009-05-18 22:18       ` Gabriel Paubert
2009-05-18 22:53         ` Medve Emilian-EMMEDVE1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242617089.18075.25.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paubert@iram.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).