From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 091D9DE035 for ; Mon, 18 May 2009 13:25:01 +1000 (EST) Subject: Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again From: Benjamin Herrenschmidt To: Gabriel Paubert In-Reply-To: <20090515181813.GA28132@iram.es> References: <20090515181813.GA28132@iram.es> Content-Type: text/plain Date: Mon, 18 May 2009 13:24:49 +1000 Message-Id: <1242617089.18075.25.camel@pasglop> Mime-Version: 1.0 Cc: LinuxPPC List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2009-05-15 at 20:18 +0200, Gabriel Paubert wrote: > Since PPC_MUTIPLATFORM was removed, it was impossible to select the > driver for mv643xx_eth on the Pegasos. Fix by allowing to select > the driver on CHRP platforms; Pegasos is a CHRP platform and the driver > will not work wihtout arch/powerpc/platforms/chrp/pegasos_eth. > > The patch also removes all references to MV64360 config option which > no more exists. > > Signed-off-by: Gabriel Paubert Please break that up into 2 different patches. The arch/powerpc one that removes the reference from IRQ_ALL_CPUs and the drivers/net/ one which should be set to the netdev mailing list. Thanks ! Cheers, Ben. > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index a0d1146..1dfeb62 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -360,7 +360,7 @@ config PPCBUG_NVRAM > > config IRQ_ALL_CPUS > bool "Distribute interrupts on all CPUs by default" > - depends on SMP && !MV64360 > + depends on SMP > help > This option gives the kernel permission to distribute IRQs across > multiple CPUs. Saying N here will route all IRQs to the first > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index 214a92d..6fc0ff4 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND > > config MV643XX_ETH > tristate "Marvell Discovery (643XX) and Orion ethernet support" > - depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) || PLAT_ORION > + depends on MV64X60 || PPC_CHRP || PLAT_ORION > select INET_LRO > select PHYLIB > help