* [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S
@ 2009-05-18 4:49 Torez Smith
2009-05-18 5:12 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Torez Smith @ 2009-05-18 4:49 UTC (permalink / raw)
To: Benjamin Herrenschmidt, linuxppc-dev
File arch/powerpc/mm/tlb_nohash_low.S defines various processor specific low level TLB invalidation. Most all family of validations are grouped via pre-processor defines with the intent we error out if we reach the end and our platform is not represented. Given this, the last few lines of the file should look similar to the following....
<< SNIP >>
1: wrtee r10
blr
#else
#error Unsupported processor type !
#endif
However, the #else is incorrectly written as #elif. On some of the newer compilers/assemblers, this will not successfully assemble and will cause an error.
Signed-off-by: Torez Smith <lnxtorez@linux.vnet.ibm.com>
---
Index: linux-2.6.29/arch/powerpc/mm/tlb_nohash_low.S
===================================================================
--- linux-2.6.29.orig/arch/powerpc/mm/tlb_nohash_low.S 2009-05-17 21:31:20.000000000 -0500
+++ linux-2.6.29/arch/powerpc/mm/tlb_nohash_low.S 2009-05-17 21:31:40.000000000 -0500
@@ -161,6 +161,6 @@
isync
1: wrtee r10
blr
-#elif
+#else
#error Unsupported processor type !
#endif
--
Torez Smith
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S
2009-05-18 4:49 [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S Torez Smith
@ 2009-05-18 5:12 ` Benjamin Herrenschmidt
2009-05-18 5:47 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2009-05-18 5:12 UTC (permalink / raw)
To: Torez Smith; +Cc: linuxppc-dev
On Sun, 2009-05-17 at 23:49 -0500, Torez Smith wrote:
> File arch/powerpc/mm/tlb_nohash_low.S defines various processor specific low level TLB invalidation. Most all family of validations are grouped via pre-processor defines with the intent we error out if we reach the end and our platform is not represented. Given this, the last few lines of the file should look similar to the following....
> << SNIP >>
> 1: wrtee r10
> blr
> #else
> #error Unsupported processor type !
> #endif
>
> However, the #else is incorrectly written as #elif. On some of the newer compilers/assemblers, this will not successfully assemble and will cause an error.
Thanks, but it's been fixed already :-)
See commit b62c31ae401c6df25c61b206681a6e904ef97169.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S
2009-05-18 5:12 ` Benjamin Herrenschmidt
@ 2009-05-18 5:47 ` Stephen Rothwell
2009-05-18 5:52 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2009-05-18 5:47 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Torez Smith
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
Hi Ben,
On Mon, 18 May 2009 15:12:03 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> Thanks, but it's been fixed already :-)
>
> See commit b62c31ae401c6df25c61b206681a6e904ef97169.
Should this be submitted for 2.6.29 stable?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S
2009-05-18 5:47 ` Stephen Rothwell
@ 2009-05-18 5:52 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2009-05-18 5:52 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linuxppc-dev, Torez Smith
On Mon, 2009-05-18 at 15:47 +1000, Stephen Rothwell wrote:
> Hi Ben,
>
> On Mon, 18 May 2009 15:12:03 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > Thanks, but it's been fixed already :-)
> >
> > See commit b62c31ae401c6df25c61b206681a6e904ef97169.
>
> Should this be submitted for 2.6.29 stable?
Probably, will do.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-05-18 5:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-18 4:49 [PATCH] bug fix in arch/powerpc/mm/tlb_nohash_low.S Torez Smith
2009-05-18 5:12 ` Benjamin Herrenschmidt
2009-05-18 5:47 ` Stephen Rothwell
2009-05-18 5:52 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).