linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Daniel Ng <daniel.ng1234@gmail.com>,
	Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
Subject: Re: MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error
Date: Tue, 02 Jun 2009 14:42:16 +1000	[thread overview]
Message-ID: <1243917736.5308.19.camel@pasglop> (raw)
In-Reply-To: <20090602043819.GA1069@pengutronix.de>

On Tue, 2009-06-02 at 06:38 +0200, Wolfram Sang wrote:
> I fully agree that the proper way is using the device tree. I can't recall
> exactly why this wasn't an option to me a year ago, but I assume it had
> something to do with this ugly out-of-tree-driver. I wouldn't really argue
> about this patch, I just thought it might be useful as it seems there are
> people trying to do the same for some reason. Then again, maybe it should be
> skipped, as it makes it easier to not use the proper solution (= device tree)
> :)

Whether the driver is in or out of tree shouldn't affect the device-tree
which represents the -devices- on the system regardless of whether a
driver is in-tree or not.

So while some people might flinch, I don't necessarily object to adding
nodes in the device-trees we ship with the kernel for things for which
we don't have an in-tree driver.

It does mean however that the risk of such nodes containing busted
informations that aren't spotted because nobody has the driver to test
is higher but that's a risk you are taking with out of tree drivers
anyway.

Cheers,
Ben.

  reply	other threads:[~2009-06-02  4:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28  7:37 MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error Daniel Ng
2009-05-28 10:33 ` Norbert van Bolhuis
2009-05-28 12:33   ` Wolfram Sang
2009-05-29  0:46     ` Daniel Ng
2009-05-29  8:31       ` [PATCH] powerpc/cpm2: make cpm2_pic the default host Wolfram Sang
2009-05-29 10:56     ` MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error Frank Svendsbøe
2009-05-29 17:18       ` Scott Wood
2009-05-30 20:22         ` Frank Svendsbøe
2009-06-02  0:48           ` Benjamin Herrenschmidt
2009-06-02  0:47     ` Benjamin Herrenschmidt
2009-06-02  4:38       ` Wolfram Sang
2009-06-02  4:42         ` Benjamin Herrenschmidt [this message]
2009-06-02  0:46   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243917736.5308.19.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=daniel.ng1234@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=nvbolhuis@aimvalley.nl \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).