From: Nate Case <ncase@xes-inc.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 -next] powerpc/85xx: Add support for X-ES MPC85xx boards
Date: Wed, 10 Jun 2009 19:35:23 -0500 [thread overview]
Message-ID: <1244680523.29684.1628.camel@localhost.localdomain> (raw)
In-Reply-To: <DF329655-9763-42EA-8170-645337949CF3@kernel.crashing.org>
On Wed, 2009-06-10 at 18:24 -0500, Kumar Gala wrote:
> > + form-factor = "6U cPCI";
> > + boot-bank = <0x0>; /* 0: Primary flash, 1: Secondary flash */
>
> I'm not a fan of taking device trees with properties that are
> specified anywhere.
I can just delete them for now. They're purely informational at this
point, but might be used in the future.
> > + soc8572@ef000000 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + device_type = "soc";
> > + compatible = "simple-bus";
>
> should have a compat like:
>
> compatible = "fsl,mpc8572-immr", "simple-bus";
Are you sure about this? I only see "simple-bus" in the mpc8572ds.dts
files in mainline and your next branch -- so I was just following your
lead here.
I'll split up the patch as well. It's not obvious where the 4-line boot
wrapper change should go, so I can make that one separate as well unless
you object.
--
Nate Case <ncase@xes-inc.com>
next prev parent reply other threads:[~2009-06-11 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 22:30 [PATCH v2 -next] powerpc/85xx: Add support for X-ES MPC85xx boards Nate Case
2009-06-10 23:24 ` Kumar Gala
2009-06-11 0:35 ` Nate Case [this message]
2009-06-11 1:32 ` David Gibson
2009-06-11 16:04 ` Nate Case
2009-06-11 23:29 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244680523.29684.1628.camel@localhost.localdomain \
--to=ncase@xes-inc.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).