* [PATCH] drivers/hvc: add missing __devexit_p() @ 2009-05-18 7:42 Mike Frysinger 2009-05-18 7:44 ` [PATCH v2] " Mike Frysinger 0 siblings, 1 reply; 3+ messages in thread From: Mike Frysinger @ 2009-05-18 7:42 UTC (permalink / raw) To: linux-kernel; +Cc: linuxppc-dev The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled. Signed-off-by: Mike Frysinger <vapier@gentoo.org> CC: linuxppc-dev@ozlabs.org CC: linux-kernel@vger.kernel.org --- drivers/char/hvc_iseries.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/hvc_iseries.c b/drivers/char/hvc_iseries.c index 449727b..936d05b 100644 --- a/drivers/char/hvc_iseries.c +++ b/drivers/char/hvc_iseries.c @@ -241,7 +241,7 @@ static int __devexit hvc_vio_remove(struct vio_dev *vdev) static struct vio_driver hvc_vio_driver = { .id_table = hvc_driver_table, .probe = hvc_vio_probe, - .remove = hvc_vio_remove, + .remove = __devexit_p(hvc_vio_remove), .driver = { .name = hvc_driver_name, .owner = THIS_MODULE, -- 1.6.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] drivers/hvc: add missing __devexit_p() 2009-05-18 7:42 [PATCH] drivers/hvc: add missing __devexit_p() Mike Frysinger @ 2009-05-18 7:44 ` Mike Frysinger 2009-06-16 3:30 ` Benjamin Herrenschmidt 0 siblings, 1 reply; 3+ messages in thread From: Mike Frysinger @ 2009-05-18 7:44 UTC (permalink / raw) To: linux-kernel; +Cc: linuxppc-dev The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled. Signed-off-by: Mike Frysinger <vapier@gentoo.org> CC: linuxppc-dev@ozlabs.org --- v2 - include all hvc files drivers/char/hvc_iseries.c | 2 +- drivers/char/hvc_vio.c | 2 +- drivers/char/hvcs.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/hvc_iseries.c b/drivers/char/hvc_iseries.c index 449727b..936d05b 100644 --- a/drivers/char/hvc_iseries.c +++ b/drivers/char/hvc_iseries.c @@ -241,7 +241,7 @@ static int __devexit hvc_vio_remove(struct vio_dev *vdev) static struct vio_driver hvc_vio_driver = { .id_table = hvc_driver_table, .probe = hvc_vio_probe, - .remove = hvc_vio_remove, + .remove = __devexit_p(hvc_vio_remove), .driver = { .name = hvc_driver_name, .owner = THIS_MODULE, diff --git a/drivers/char/hvc_vio.c b/drivers/char/hvc_vio.c index bd62dc8..c72b994 100644 --- a/drivers/char/hvc_vio.c +++ b/drivers/char/hvc_vio.c @@ -113,7 +113,7 @@ static int __devexit hvc_vio_remove(struct vio_dev *vdev) static struct vio_driver hvc_vio_driver = { .id_table = hvc_driver_table, .probe = hvc_vio_probe, - .remove = hvc_vio_remove, + .remove = __devexit_p(hvc_vio_remove), .driver = { .name = hvc_driver_name, .owner = THIS_MODULE, diff --git a/drivers/char/hvcs.c b/drivers/char/hvcs.c index c76bccf..2724d62 100644 --- a/drivers/char/hvcs.c +++ b/drivers/char/hvcs.c @@ -868,7 +868,7 @@ static int __devexit hvcs_remove(struct vio_dev *dev) static struct vio_driver hvcs_vio_driver = { .id_table = hvcs_driver_table, .probe = hvcs_probe, - .remove = hvcs_remove, + .remove = __devexit_p(hvcs_remove), .driver = { .name = hvcs_driver_name, .owner = THIS_MODULE, -- 1.6.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drivers/hvc: add missing __devexit_p() 2009-05-18 7:44 ` [PATCH v2] " Mike Frysinger @ 2009-06-16 3:30 ` Benjamin Herrenschmidt 0 siblings, 0 replies; 3+ messages in thread From: Benjamin Herrenschmidt @ 2009-06-16 3:30 UTC (permalink / raw) To: Mike Frysinger; +Cc: linuxppc-dev, Andrew Morton, linux-kernel On Mon, 2009-05-18 at 03:44 -0400, Mike Frysinger wrote: > The remove function uses __devexit, so the .remove assignment needs > __devexit_p() to fix a build error with hotplug disabled. > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > CC: linuxppc-dev@ozlabs.org > --- > v2 Thanks. Andrew, I'm picking this one up. Cheers, Ben. > - include all hvc files > > drivers/char/hvc_iseries.c | 2 +- > drivers/char/hvc_vio.c | 2 +- > drivers/char/hvcs.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/hvc_iseries.c b/drivers/char/hvc_iseries.c > index 449727b..936d05b 100644 > --- a/drivers/char/hvc_iseries.c > +++ b/drivers/char/hvc_iseries.c > @@ -241,7 +241,7 @@ static int __devexit hvc_vio_remove(struct vio_dev *vdev) > static struct vio_driver hvc_vio_driver = { > .id_table = hvc_driver_table, > .probe = hvc_vio_probe, > - .remove = hvc_vio_remove, > + .remove = __devexit_p(hvc_vio_remove), > .driver = { > .name = hvc_driver_name, > .owner = THIS_MODULE, > diff --git a/drivers/char/hvc_vio.c b/drivers/char/hvc_vio.c > index bd62dc8..c72b994 100644 > --- a/drivers/char/hvc_vio.c > +++ b/drivers/char/hvc_vio.c > @@ -113,7 +113,7 @@ static int __devexit hvc_vio_remove(struct vio_dev *vdev) > static struct vio_driver hvc_vio_driver = { > .id_table = hvc_driver_table, > .probe = hvc_vio_probe, > - .remove = hvc_vio_remove, > + .remove = __devexit_p(hvc_vio_remove), > .driver = { > .name = hvc_driver_name, > .owner = THIS_MODULE, > diff --git a/drivers/char/hvcs.c b/drivers/char/hvcs.c > index c76bccf..2724d62 100644 > --- a/drivers/char/hvcs.c > +++ b/drivers/char/hvcs.c > @@ -868,7 +868,7 @@ static int __devexit hvcs_remove(struct vio_dev *dev) > static struct vio_driver hvcs_vio_driver = { > .id_table = hvcs_driver_table, > .probe = hvcs_probe, > - .remove = hvcs_remove, > + .remove = __devexit_p(hvcs_remove), > .driver = { > .name = hvcs_driver_name, > .owner = THIS_MODULE, ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-16 3:32 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-05-18 7:42 [PATCH] drivers/hvc: add missing __devexit_p() Mike Frysinger 2009-05-18 7:44 ` [PATCH v2] " Mike Frysinger 2009-06-16 3:30 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).