From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: killing use of ppc_md.init
Date: Fri, 19 Jun 2009 08:18:18 +1000 [thread overview]
Message-ID: <1245363498.8693.3.camel@pasglop> (raw)
In-Reply-To: <C81AEED1-5CEC-42B8-A893-5E6BDDD4EC54@kernel.crashing.org>
On Thu, 2009-06-18 at 09:38 -0500, Kumar Gala wrote:
> ppc_md.init only exists on ppc32 and seems like its pretty useless
> today. The users seem to fall into two classes:
>
> 1. called to do of_platform_bus_probe() - most platforms use
> machine_device_initcall() for this
> 2. some platform init code which seems like it could move into
> setup_arch().
>
> The second one seems to only be on amigaone and chrp. Anyone know if
> there is any harm in moving the amigaone_init() into
> amigaone_setup_arch() and similarly on chrp chrp_init2() into
> chrp_setup_arch().
We might kill it ... and revive it differently :-)
Yes, the current ppc_init() can probably just go.
However, we probably also want to add a call from init/main.c back to
the architectures and ppc_md. in our case that is right after mm_init().
Right now, we do way too many things at setup_arch() (or even before
that on ppc64) which induces all sorts of pain due to having to use
bootmem etc...
Now that slab is available much earlier, before init_IRQ() and
time_init(), we should consider moving a whole bunch of stuff somewhere
later in the boot process to simplify the code etc...
Cheers,
Ben.
next prev parent reply other threads:[~2009-06-18 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 14:38 killing use of ppc_md.init Kumar Gala
2009-06-18 22:18 ` Benjamin Herrenschmidt [this message]
2009-06-19 8:30 ` Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245363498.8693.3.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).