From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] lib: Provide generic atomic64_t implementation
Date: Fri, 19 Jun 2009 10:46:14 +1000 [thread overview]
Message-ID: <1245372374.16880.0.camel@pasglop> (raw)
In-Reply-To: <8bd0f97a0906181655jd68835fg10fe0783b6a6068d@mail.gmail.com>
On Thu, 2009-06-18 at 19:55 -0400, Mike Frysinger wrote:
> On Sat, Jun 13, 2009 at 03:10, Paul Mackerras wrote:
> > +typedef struct {
> > + long long counter;
> > +} atomic64_t;
>
> lack of volatile seems odd compared to:
> include/linux/types.h:
> typedef struct {
> volatile int counter;
> } atomic_t;
Since the counter is only accessed within a spinlock, the volatile
wouldn't be very useful here.
Cheers,
Ben.
next prev parent reply other threads:[~2009-06-19 0:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 7:10 [PATCH 1/2] lib: Provide generic atomic64_t implementation Paul Mackerras
2009-06-13 20:13 ` Linus Torvalds
2009-06-13 20:25 ` Linus Torvalds
2009-06-13 20:56 ` Ingo Molnar
2009-06-14 11:53 ` Avi Kivity
2009-06-14 12:21 ` Paul Mackerras
2009-06-14 13:04 ` Avi Kivity
2009-06-15 2:44 ` Roland Dreier
2009-06-15 4:30 ` Paul Mackerras
2009-06-16 22:27 ` Gabriel Paubert
2009-06-13 21:53 ` Arnd Bergmann
2009-06-18 23:55 ` Mike Frysinger
2009-06-19 0:46 ` Benjamin Herrenschmidt [this message]
2009-06-19 0:47 ` Paul Mackerras
2009-06-19 0:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245372374.16880.0.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).