From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix another bug in move of altivec code to vector.S
Date: Sat, 11 Jul 2009 09:49:27 +1000 [thread overview]
Message-ID: <1247269767.21776.17.camel@pasglop> (raw)
In-Reply-To: <m2iqi0w83z.fsf@igel.home>
On Fri, 2009-07-10 at 23:17 +0200, Andreas Schwab wrote:
> When moving load_up_altivec to vector.S a typo in a comment caused a
> thinko setting the wrong variable.
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Good catch, thanks.
Cheers,
Ben.
> ---
> diff --git a/arch/powerpc/kernel/vector.S b/arch/powerpc/kernel/vector.S
> index ef36cbb..ea4d646 100644
> --- a/arch/powerpc/kernel/vector.S
> +++ b/arch/powerpc/kernel/vector.S
> @@ -80,10 +80,10 @@ _GLOBAL(load_up_altivec)
> mtvscr vr0
> REST_32VRS(0,r4,r5)
> #ifndef CONFIG_SMP
> - /* Update last_task_used_math to 'current' */
> + /* Update last_task_used_altivec to 'current' */
> subi r4,r5,THREAD /* Back to 'current' */
> fromreal(r4)
> - PPC_STL r4,ADDROFF(last_task_used_math)(r3)
> + PPC_STL r4,ADDROFF(last_task_used_altivec)(r3)
> #endif /* CONFIG_SMP */
> /* restore registers and return */
> blr
> @@ -172,7 +172,7 @@ _GLOBAL(load_up_vsx)
> oris r12,r12,MSR_VSX@h
> std r12,_MSR(r1)
> #ifndef CONFIG_SMP
> - /* Update last_task_used_math to 'current' */
> + /* Update last_task_used_vsx to 'current' */
> ld r4,PACACURRENT(r13)
> std r4,0(r3)
> #endif /* CONFIG_SMP */
>
prev parent reply other threads:[~2009-07-10 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 21:17 [PATCH] powerpc: Fix another bug in move of altivec code to vector.S Andreas Schwab
2009-07-10 23:49 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247269767.21776.17.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).