From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id A7E3BB7087 for ; Fri, 17 Jul 2009 10:29:19 +1000 (EST) Received: from bilbo.ozlabs.org (bilbo.ozlabs.org [203.10.76.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "bilbo.ozlabs.org", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 9425CDDD1C for ; Fri, 17 Jul 2009 10:29:19 +1000 (EST) Subject: Re: [PATCH] kmemleak: Allow kmemleak to be built on powerpc From: Michael Ellerman To: Catalin Marinas In-Reply-To: <1247766739.27689.63.camel@pc1117.cambridge.arm.com> References: <1247730230.18228.5.camel@concordia> <1247766739.27689.63.camel@pc1117.cambridge.arm.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-/H8X+2NlzXHn3PfQhz1S" Date: Fri, 17 Jul 2009 10:29:18 +1000 Message-Id: <1247790558.16836.4.camel@concordia> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org Reply-To: michael@ellerman.id.au List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --=-/H8X+2NlzXHn3PfQhz1S Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2009-07-16 at 18:52 +0100, Catalin Marinas wrote: > On Thu, 2009-07-16 at 17:43 +1000, Michael Ellerman wrote: > > On Thu, 2009-07-16 at 11:25 +1000, Michael Ellerman wrote: > > > Very lightly tested, doesn't crash the kernel. > > >=20 > > > Signed-off-by: Michael Ellerman > > > --- > > >=20 > > > It doesn't look like we actually need to add any support in the > > > arch code - or is there something I'm missing? > >=20 > > Hmm, I think we want to add annotations in lib/lmb.c don't we? That's > > our low-level pre-bootmem allocator. >=20 > Yes, I think so (I'm not using this on ARM or x86 so I can't really test > it). Without these hooks, there kmemleak reports aren't that useful > (probably too many). The wrinkle is that lmb never frees, so by definition it can't leak :) But we could have memory allocated with lmb that has pointers to other objects allocated later, and we want kmemleak to scan the lmb allocated blocks to find those references. So the question is do we need to annotate lmb so that will happen, or does kmemleak scan all kernel memory, regardless of where it's allocated? cheers --=-/H8X+2NlzXHn3PfQhz1S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkpfxdsACgkQdSjSd0sB4dIWdwCfRmnk6LmFDjkEAhY4v/oWyCcF M/oAoMQu72Hip2Z+ShBraZeSM3AB7osP =kAzT -----END PGP SIGNATURE----- --=-/H8X+2NlzXHn3PfQhz1S--