From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bastian Blank <bastian@waldi.eu.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Disable PowerMac cpufreq on SMP kernels
Date: Thu, 13 Aug 2009 16:14:58 +1000 [thread overview]
Message-ID: <1250144098.3587.111.camel@pasglop> (raw)
In-Reply-To: <20090811093931.GA15940@wavehammer.waldi.eu.org>
On Tue, 2009-08-11 at 11:39 +0200, Bastian Blank wrote:
> The build of a PowerMac 32bit kernel currently fails with
>
> error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
>
> This patch just disables this driver on SMP kernels, as it is obviously
> not supported.
>
> Signed-off-by: Bastian Blank <waldi@debian.org>
Why not remove the #error instead ? :-) I don't think it's still
meaningful, especially since we use the timebase for delays nowadays
which doesn't depend on the CPU frequency...
Ben.
> diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
> index 04a8061..99d3564 100644
> --- a/arch/powerpc/platforms/Kconfig
> +++ b/arch/powerpc/platforms/Kconfig
> @@ -149,7 +149,7 @@ menu "CPU Frequency drivers"
>
> config CPU_FREQ_PMAC
> bool "Support for Apple PowerBooks"
> - depends on ADB_PMU && PPC32
> + depends on ADB_PMU && PPC32 && !SMP
> select CPU_FREQ_TABLE
> help
> This adds support for frequency switching on Apple PowerBooks,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2009-08-13 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 9:39 [PATCH] Disable PowerMac cpufreq on SMP kernels Bastian Blank
2009-08-13 6:14 ` Benjamin Herrenschmidt [this message]
2009-08-13 9:30 ` [PATCH] Remove SMP warning from PowerMac cpufreq Bastian Blank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250144098.3587.111.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bastian@waldi.eu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).