From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linuxppc-dev@ozlabs.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Add kmemleak annotations to lmb.c
Date: Fri, 14 Aug 2009 17:56:40 +1000 [thread overview]
Message-ID: <1250236600.24143.34.camel@pasglop> (raw)
In-Reply-To: <1250178041.14019.34.camel@pc1117.cambridge.arm.com>
On Thu, 2009-08-13 at 16:40 +0100, Catalin Marinas wrote:
> On Thu, 2009-08-13 at 13:01 +1000, Michael Ellerman wrote:
> > We don't actually want kmemleak to track the lmb allocations, so we
> > pass min_count as 0. However telling kmemleak about lmb allocations
> > allows it to scan that memory for pointers to other memory that is
> > tracked by kmemleak, ie. slab allocations etc.
>
> Looks alright to me (though I haven't tested it). You can add a
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Actually, Milton pointed to me that we may not want to allow all
LMB chunks to be scanned by kmemleaks, things like the DART hole
that's taken out of the linear mapping for example may need to
be avoided, though I'm not sure what would be the right way to
do it.
Cheers,
Ben.
next prev parent reply other threads:[~2009-08-14 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 3:01 [PATCH] Add kmemleak annotations to lmb.c Michael Ellerman
2009-08-13 15:40 ` Catalin Marinas
2009-08-14 7:56 ` Benjamin Herrenschmidt [this message]
2009-08-14 8:25 ` Catalin Marinas
2009-08-14 19:49 ` David Miller
2009-08-14 21:57 ` Catalin Marinas
2009-08-20 6:01 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2009-08-10 5:05 Michael Ellerman
2009-08-13 2:23 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250236600.24143.34.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).