From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Fix __flush_icache_range on 44x
Date: Tue, 18 Aug 2009 07:46:28 +1000 [thread overview]
Message-ID: <1250545588.4861.5.camel@pasglop> (raw)
In-Reply-To: <20090817160713.GE8710@zod.rchland.ibm.com>
On Mon, 2009-08-17 at 12:07 -0400, Josh Boyer wrote:
>
> Olof pointed out that we could probably do the iccci before the icbi loop and
> just skip that loop entirely on 44x. This is most certainly valid, but at
> this particular moment I don't have time to try and reproduce the issue with
> an alternative fix and I wanted to get _something_ out there to fix the issue.
>
> I suck for that, I know.
Well, I can massage your patch if you want. The fact is, the icbi loop
and iccci are definitely redundant :-)
Cheers,
Ben.
next prev parent reply other threads:[~2009-08-17 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 13:41 [PATCH] powerpc: Fix __flush_icache_range on 44x Josh Boyer
2009-08-17 16:07 ` Josh Boyer
2009-08-17 21:46 ` Benjamin Herrenschmidt [this message]
2009-08-18 0:16 ` Josh Boyer
2009-08-18 0:54 ` Benjamin Herrenschmidt
2009-08-19 7:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250545588.4861.5.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).