From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: lmb: Remove __init from lmb_end_of_DRAM()
Date: Fri, 28 Aug 2009 17:21:28 +1000 [thread overview]
Message-ID: <1251444088.20467.169.camel@pasglop> (raw)
In-Reply-To: <200908271959.n7RJxNvV008624@hera.kernel.org>
On Thu, 2009-08-27 at 19:59 +0000, Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/linus/4f8ee2c9cc0e885d2bb50ef26db66150ab25213e
> Commit: 4f8ee2c9cc0e885d2bb50ef26db66150ab25213e
> Parent: cf481442f2e086316ed8a1b3046f00ad23632ac4
> Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> AuthorDate: Thu Aug 27 17:20:30 2009 +1000
> Committer: Linus Torvalds <torvalds@linux-foundation.org>
> CommitDate: Thu Aug 27 12:25:26 2009 -0700
>
> lmb: Remove __init from lmb_end_of_DRAM()
>
> We call lmb_end_of_DRAM() to test whether a DMA mask is ok on a machine
> without IOMMU, but this function is marked as __init.
>
> I don't think there's a clean way to get the top of RAM max_pfn doesn't
> appear to include highmem or I missed (or we have a bug :-) so for now,
> let's just avoid having a broken 2.6.31 by making this function
> non-__init and we can revisit later.
And another brown paper bag for me ! Patch is fine, but doesn't do the
job because some idiot (me) didn't actually test (it looked so obvious)
and didn't notice somebody had the strange idea to also put __init on
the declaration in the .h file ! Ugh.
I'll send another patch later, have to run home now.
Cheers,
Ben.
parent reply other threads:[~2009-08-28 7:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200908271959.n7RJxNvV008624@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251444088.20467.169.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).