From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/85xx: Fix SMP compile error and allow NULL for smp_ops
Date: Wed, 09 Sep 2009 07:31:12 +1000 [thread overview]
Message-ID: <1252445472.4950.96.camel@pasglop> (raw)
In-Reply-To: <1252437668-28508-1-git-send-email-galak@kernel.crashing.org>
On Tue, 2009-09-08 at 14:21 -0500, Kumar Gala wrote:
>
> struct smp_ops_t smp_85xx_ops = {
> + .message_pass = NULL,
> + .probe = NULL,
> .kick_cpu = smp_85xx_kick_cpu,
> + .setup_cpu = NULL,
> };
Why explicitely setting those to NULL ?
Cheers,
Ben.
> -static int __init smp_dummy_probe(void)
> -{
> - return NR_CPUS;
> -}
> -
> void __init mpc85xx_smp_init(void)
> {
> struct device_node *np;
>
> - smp_85xx_ops.message_pass = NULL;
> -
> np = of_find_node_by_type(NULL, "open-pic");
> if (np) {
> smp_85xx_ops.probe = smp_mpic_probe;
> smp_85xx_ops.setup_cpu = smp_85xx_setup_cpu;
> smp_85xx_ops.message_pass = smp_mpic_message_pass;
> - } else {
> - smp_85xx_ops.probe = smp_dummy_probe;
> - smp_85xx_ops.setup_cpu = smp_85xx_basic_setup;
> }
>
> if (cpu_has_feature(CPU_FTR_DBELL))
next prev parent reply other threads:[~2009-09-08 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 19:21 [PATCH] powerpc/85xx: Fix SMP compile error and allow NULL for smp_ops Kumar Gala
2009-09-08 21:31 ` Benjamin Herrenschmidt [this message]
2009-09-09 3:08 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252445472.4950.96.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).