linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@fifo99.com>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
	Arun R Bharadwaj <arun@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org,
	"Darrick J. Wong" <djwong@us.ibm.com>
Subject: Re: [PATCH v3 1/3] pSeries: cede latency specifier helper function.
Date: Tue, 15 Sep 2009 07:45:05 -0700	[thread overview]
Message-ID: <1253025905.11643.335.camel@desktop> (raw)
In-Reply-To: <20090915120701.20523.94109.stgit@sofia.in.ibm.com>

On Tue, 2009-09-15 at 17:37 +0530, Gautham R Shenoy wrote:
>         // Used to pass parms from the OS to PLIC for SetAsrAndRfid
>         u64     saved_gpr3;             // Saved GPR3                   x20-x27
>         u64     saved_gpr4;             // Saved GPR4                   x28-x2F
> -       u64     saved_gpr5;             // Saved GPR5                   x30-x37
> +       union {
> +               u64     saved_gpr5;     // Saved GPR5                   x30-x37
> +               struct {
> +                       u8      cede_latency_hint;  //                  x30
> +                       u8      reserved[7];        //                  x31-x36
> +               } fields;
> +       } gpr5_dword;
> +
>  
>         u8      dtl_enable_mask;        // Dispatch Trace Log mask      x38-x38
>         u8      donate_dedicated_cpu;   // Donate dedicated CPU cycles  x39-x39

Could you drop the C99 style comments (use /* */ instead)? If you run
checkpatch on this it will error on these lines..

Daniel

  reply	other threads:[~2009-09-15 14:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 12:06 [PATCH v3 0/3] cpu: pseries: Cpu offline states framework Gautham R Shenoy
2009-09-15 12:07 ` [PATCH v3 1/3] pSeries: cede latency specifier helper function Gautham R Shenoy
2009-09-15 14:45   ` Daniel Walker [this message]
2009-09-15 12:07 ` [PATCH v3 2/3] cpu: Offline state Framework Gautham R Shenoy
2009-09-30 17:31   ` Randy Dunlap
2009-09-15 12:07 ` [PATCH v3 3/3] cpu: Implement cpu-offline-state callbacks for pSeries Gautham R Shenoy
2009-09-15 12:11 ` [PATCH v3 0/3] cpu: pseries: Cpu offline states framework Peter Zijlstra
2009-09-15 13:21   ` Michael Ellerman
2009-09-15 14:58   ` Balbir Singh
2009-09-16  7:48     ` Heiko Carstens
2009-09-24  0:52       ` Benjamin Herrenschmidt
2009-09-16 15:28   ` Dipankar Sarma
2009-09-16 15:32     ` Peter Zijlstra
2009-09-16 16:24       ` Dipankar Sarma
2009-09-16 16:35         ` Peter Zijlstra
2009-09-16 17:03           ` Vaidyanathan Srinivasan
2009-09-16 17:22             ` Peter Zijlstra
2009-09-16 20:17               ` Dipankar Sarma
2009-09-24  0:55         ` Benjamin Herrenschmidt
2009-09-24  0:51   ` Benjamin Herrenschmidt
2009-09-25 14:48     ` Peter Zijlstra
2009-09-25 21:12       ` Benjamin Herrenschmidt
2009-09-28 13:53         ` Vaidyanathan Srinivasan
2009-09-28 13:51       ` Vaidyanathan Srinivasan
2009-09-26  9:55   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253025905.11643.335.camel@desktop \
    --to=dwalker@fifo99.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=arun@linux.vnet.ibm.com \
    --cc=djwong@us.ibm.com \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).