From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: RFC: delete UART current-speed from 4xx DTS?
Date: Thu, 17 Sep 2009 07:31:06 +1000 [thread overview]
Message-ID: <1253136666.8375.288.camel@pasglop> (raw)
In-Reply-To: <20090916131943.GA14261@zod.rchland.ibm.com>
> Ok, so I think that is related to what I originally hit.
>
> I played around with removing the current-speed property on canyonlands today,
> and noticed that I would get no console output at all unless I specified a
> baudrate with console=ttyS0,115200. That was sort of contrary to what I found
> with bamboo, so I diffed the configs to see why. Bamboo has udbg enabled and
> hence has legacy_serial builtin, whereas canyonlands just has of_serial.
>
> So on boards where of_serial is the only serial driver, we need either an
> accurate current-speed property, or a specific baudrate on the command line.
> That makes a bit more tenuous to remove the properties entirely, because if
> people disable udbg and are relying on that behavior they get no more console
> output. Need to think on that a bit I guess.
>
> Alternatively, we could try patching of_serial.c to do the baudrate probe
> as well.
Well, I've always wondered why we just don't put the probe in the 8250
driver... I proposed it on the list a while back and there was no
serious objection, but then forgot about it :-)
We should do it, and check if the result is sane (looks like a standard
speed). If it is, we should then just used it.
Ben.
next prev parent reply other threads:[~2009-09-16 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 14:31 RFC: delete UART current-speed from 4xx DTS? Paul Gortmaker
2009-09-15 15:32 ` Josh Boyer
2009-09-15 19:32 ` Paul Gortmaker
2009-09-15 20:02 ` Josh Boyer
2009-09-15 20:44 ` Paul Gortmaker
2009-09-15 21:44 ` Benjamin Herrenschmidt
2009-09-16 13:19 ` Josh Boyer
2009-09-16 14:57 ` Paul Gortmaker
2009-09-16 21:31 ` Benjamin Herrenschmidt [this message]
2009-09-17 1:44 ` Josh Boyer
2009-09-23 18:15 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253136666.8375.288.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).