From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Julie Zhu <julie.zhu@xilinx.com>
Cc: greg@kroah.com, linux-usb@vger.kernel.org,
linuxppc-dev@ozlabs.org, john.linn@xilinx.com
Subject: Re: [PATCH] [V1] USB: Add support for Xilinx USB host controller
Date: Tue, 22 Sep 2009 06:49:40 +1000 [thread overview]
Message-ID: <1253566180.7103.147.camel@pasglop> (raw)
In-Reply-To: <20090921193821.CB9DF1620046@mail78-sin.bigfish.com>
On Mon, 2009-09-21 at 13:38 -0600, Julie Zhu wrote:
> + iounmap(hcd->regs);
> +err_ioremap:
> + irq_dispose_mapping(irq);
You missed that one too :-)
I'm actually considering making irq_dispose_mapping() a private
API and rename it to something like __irq_dispose_mapping() :-)
I think the only reasonable use case for it is when re-allocating
MSIs to avoid using the whole virq space.
Cheers,
Ben.
next prev parent reply other threads:[~2009-09-21 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 19:38 [PATCH] [V1] USB: Add support for Xilinx USB host controller Julie Zhu
2009-09-21 20:47 ` Grant Likely
2009-09-21 20:49 ` Benjamin Herrenschmidt [this message]
2009-09-21 22:56 ` Anton Vorontsov
2009-09-21 23:43 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253566180.7103.147.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=john.linn@xilinx.com \
--cc=julie.zhu@xilinx.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox