From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Prodyut Hazarika <phazarika@amcc.com>
Cc: Victor Gallardo <vgallardo@amcc.com>, Feng Kan <fkan@amcc.com>,
netdev@vger.kernel.org, lada.podivin@gmail.com,
Loc Ho <lho@amcc.com>,
linuxppc-dev@lists.ozlabs.org, bhutchings@solarflare.com,
prodyut hazarika <prodyuth@gmail.com>,
davem@davemloft.net
Subject: RE: [PATCH 1/2] ibm_newemac: Add Support for MAL Interrupt Coalescing
Date: Tue, 22 Sep 2009 11:09:51 +1000 [thread overview]
Message-ID: <1253581792.7103.195.camel@pasglop> (raw)
In-Reply-To: <0CA0A16855646F4FA96D25A158E299D606FFE81A@SDCEXCHANGE01.ad.amcc.com>
On Mon, 2009-09-21 at 17:53 -0700, Prodyut Hazarika wrote:
>
> In the newer revs of 460EX/GT and 405EX, we have Interrupt coalescing
> both on Tx and Rx per channel (physical not virtual), which can be
> enabled/disabled per channel via UIC. The Tx/Rx Coalesce mappings are
> defined in the dts file. But in the older revs, there is only a global
> EOP_Int_Enable in the MAL configuration register. There can be a
> possible way even for older SoCs if we use the MAL descriptor I bit
> and
> not the global EOP_Int_Enable. But to turn on/off the channel, we will
> have to go and set/clear the I bit in whole of MAL descriptor ring for
> that channel. That might be really inefficient.
>
> What would you suggest?
I wouldn't bother with the old SoCs, we should keep the current
workaround we have today for them. For the new ones, I'll have a look
and see how we can get the driver upgraded to avoid the workaround.
Don't bother with this for now. I'll dig at some stage.
Cheers,
Ben.
prev parent reply other threads:[~2009-09-22 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 22:47 [PATCH 1/2] ibm_newemac: Add Support for MAL Interrupt Coalescing Prodyut Hazarika
2009-09-21 23:41 ` Benjamin Herrenschmidt
2009-09-21 23:49 ` Prodyut Hazarika
2009-09-22 0:07 ` Benjamin Herrenschmidt
2009-09-22 0:05 ` Prodyut Hazarika
2009-09-22 0:12 ` Benjamin Herrenschmidt
2009-09-22 0:28 ` prodyut hazarika
2009-09-22 0:39 ` Benjamin Herrenschmidt
2009-09-22 0:53 ` Prodyut Hazarika
2009-09-22 1:09 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253581792.7103.195.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=fkan@amcc.com \
--cc=lada.podivin@gmail.com \
--cc=lho@amcc.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=phazarika@amcc.com \
--cc=prodyuth@gmail.com \
--cc=vgallardo@amcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).