From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: arun@linux.vnet.ibm.com
Cc: Gautham R Shenoy <ego@in.ibm.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [v5 RFC PATCH 0/7]: cpuidle/x86/POWER (REDESIGN): Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.
Date: Tue, 22 Sep 2009 09:25:59 +0200 [thread overview]
Message-ID: <1253604359.8439.278.camel@twins> (raw)
In-Reply-To: <20090922053314.GA6417@linux.vnet.ibm.com>
Much better :-)
But I'm puzzled by all the per-cpu-ish-ness of the stuff. Why would you
need to register things on a per-cpu basis?
Also:
+ list_for_each(pos, &per_cpu(cpuidle_devices_list, cpu)) {
+ temp_dev = container_of(pos, struct cpuidle_device,
+ percpu_list[cpu]);
+ if (dev == temp_dev) {
+ list_del(&temp_dev->percpu_list[cpu]);
+ cpuidle_remove_state_sysfs(temp_dev);
+ }
+ }
Looks buggy, either you want to break out of the loop on dev ==
temp_dev, or you want to use list_for_each_safe().
next prev parent reply other threads:[~2009-09-22 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 5:33 [v5 RFC PATCH 0/7]: cpuidle/x86/POWER (REDESIGN): Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER Arun R Bharadwaj
2009-09-22 5:35 ` [v5 RFC PATCH 1/7]: cpuidle: cleanup drivers/cpuidle/cpuidle.c Arun R Bharadwaj
2009-09-22 5:36 ` [v5 RFC PATCH 2/7]: cpuidle: implement a list based approach to register a set of idle routines Arun R Bharadwaj
2009-09-22 5:37 ` [v5 RFC PATCH 3/7]: x86: refactor x86 idle power management code and remove all instances of pm_idle Arun R Bharadwaj
2009-09-22 5:38 ` [v5 RFC PATCH 4/7]: POWER: enable cpuidle for POWER Arun R Bharadwaj
2009-09-22 5:39 ` [v5 RFC PATCH 5/7]: POWER/pSeries: remove dedicate/shared idle loops, which will be moved to arch/powerpc/platforms/pseries/processor_idle.c Arun R Bharadwaj
2009-09-22 5:40 ` [v5 RFC PATCH 6/7]: POWER: add a default_idle idle loop for POWER Arun R Bharadwaj
2009-09-22 5:41 ` [v5 RFC PATCH 7/7]: POWER/pSeries: implement pSeries processor idle module Arun R Bharadwaj
2009-09-22 7:25 ` Peter Zijlstra [this message]
2009-09-22 8:56 ` [v5 RFC PATCH 0/7]: cpuidle/x86/POWER (REDESIGN): Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER Arun R Bharadwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253604359.8439.278.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=arun@linux.vnet.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).