From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rex Feany <RFeany@mrv.com>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
"Weirich, Bernhard" <Bernhard.Weirich@riedel.net>
Subject: Re: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL
Date: Thu, 24 Sep 2009 12:53:35 +1000 [thread overview]
Message-ID: <1253760815.7103.379.camel@pasglop> (raw)
In-Reply-To: <20090924023840.GA16381@compile2.chatsunix.int.mrv.com>
On Wed, 2009-09-23 at 19:38 -0700, Rex Feany wrote:
> Thus spake Benjamin Herrenschmidt (benh@kernel.crashing.org):
>
> > Hrm. This is really strange...
>
> Is this a problem? in pte-8xx.h you added:
>
> +#define _PAGE_SPECIAL 0x0008 /* SW entry, forced to 0 by the TLB miss */
>
> but there is already this:
>
> #define _PAGE_EXEC 0x0008 /* software: i-cache coherency required */
Ohhh... you aren't using upstream ! That explains :-)
I removed _PAGE_EXEC from 8xx (since it doesn't use it for anything)
recently.
I think the best option is to go for Bernhard's patch for "stable" and
my patch for upstream, so that "stable" gets the bug fix without the
feature of _PAGE_SPECIAL and upstream gets it both.
Cheers,
Ben.
prev parent reply other threads:[~2009-09-24 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 4:12 [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL Benjamin Herrenschmidt
2009-09-23 6:44 ` Weirich, Bernhard
2009-09-24 0:53 ` Rex Feany
2009-09-24 1:13 ` Benjamin Herrenschmidt
2009-09-24 1:40 ` Benjamin Herrenschmidt
2009-09-24 2:38 ` Rex Feany
2009-09-24 2:53 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253760815.7103.379.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Bernhard.Weirich@riedel.net \
--cc=RFeany@mrv.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).