From: Hollis Blanchard <hollisb@us.ibm.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: sfr@canb.auug.org.au, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-next@vger.kernel.org,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: linux-next: tree build failure
Date: Tue, 29 Sep 2009 16:39:32 -0700 [thread overview]
Message-ID: <1254267572.15622.1621.camel@slab.beaverton.ibm.com> (raw)
In-Reply-To: <4AC1E15502000078000516B5@vpn.id2.novell.com>
On Tue, 2009-09-29 at 10:28 +0100, Jan Beulich wrote:
> >>> Hollis Blanchard 09/29/09 2:00 AM >>>
> >First, I think there is a real bug here, and the code should read like
> >this (to match the comment):
> > /* type has to be known at build time for optimization */
> >- BUILD_BUG_ON(__builtin_constant_p(type));
> >+ BUILD_BUG_ON(!__builtin_constant_p(type));
> >
> >However, I get the same build error *both* ways, i.e.
> >__builtin_constant_p(type) evaluates to both 0 and 1? Either that, or
> >the new BUILD_BUG_ON() macro isn't working...
>
> No, at this point of the compilation process it's neither zero nor one,
> it's simply considered non-constant by the compiler at that stage
> (this builtin is used for optimization, not during parsing, and the
> error gets generated when the body of the function gets parsed,
> not when code gets generated from it).
I think I see what you're saying. Do you have a fix to suggest?
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2009-09-29 23:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 9:28 linux-next: tree build failure Jan Beulich
2009-09-29 9:51 ` roel kluin
2009-09-30 6:29 ` Jan Beulich
2009-09-29 23:39 ` Hollis Blanchard [this message]
2009-09-30 6:35 ` Jan Beulich
2009-10-02 15:48 ` Hollis Blanchard
2009-10-05 6:58 ` Jan Beulich
2009-10-09 19:14 ` Hollis Blanchard
2009-10-14 22:57 ` Hollis Blanchard
2009-10-15 7:27 ` Jan Beulich
2009-10-19 18:19 ` Hollis Blanchard
2009-10-20 1:12 ` Rusty Russell
2009-10-20 1:29 ` Hollis Blanchard
2009-10-20 3:45 ` [PATCH] BUILD_BUG_ON: make it handle more cases Rusty Russell
2009-10-20 13:58 ` Américo Wang
2009-10-20 14:43 ` Alan Jenkins
2009-10-23 1:50 ` Américo Wang
2009-10-22 21:04 ` Hollis Blanchard
2009-10-29 21:30 ` Hollis Blanchard
2009-11-05 0:20 ` Stephen Rothwell
2009-11-05 6:28 ` Rusty Russell
2009-11-05 6:37 ` Rusty Russell
2009-11-05 6:38 ` Stephen Rothwell
2009-11-06 6:30 ` Rusty Russell
2009-11-05 6:01 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-09-24 5:21 linux-next: tree build failure Stephen Rothwell
2009-09-29 0:00 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254267572.15622.1621.camel@slab.beaverton.ibm.com \
--to=hollisb@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=jbeulich@novell.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).