From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: Scott Wood <scottwood@freescale.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Rex Feany <RFeany@mrv.com>
Subject: Re: [PATCH 2/6] 8xx: Update TLB asm so it behaves as linux mm expects.
Date: Fri, 09 Oct 2009 17:30:01 +1100 [thread overview]
Message-ID: <1255069801.2861.2.camel@pasglop> (raw)
In-Reply-To: <OF6A111C97.D8A7A6A3-ONC125764A.00210BB5-C125764A.002271AC@transmode.se>
On Fri, 2009-10-09 at 08:16 +0200, Joakim Tjernlund wrote:
> Which will be fixed once I activate:
> #if 0 /* Not yet */
> /* Honour kernel RO, User NA */
> andi. r11, r10, _PAGE_USER | _PAGE_RW
> bne- cr0, 5f
> ori r10,r10, 0x200 /* Extended encoding, bit 22 */
> #endif
Which will be more code including a conditional than my proposed
trick :-) I'll try to write the asm for you later.
> Not convinced that your trick will be a win. The other
> bits will need to move around too. Maybe I misunderstand
> something?
I'll write some code to show you what I have in mind later.
Cheers,
Ben.
next prev parent reply other threads:[~2009-10-09 6:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 13:24 [PATCH 0/6] 8xx MMU fixes Joakim Tjernlund
2009-10-08 13:24 ` [PATCH 1/6] 8xx: DTLB Error must check for more errors Joakim Tjernlund
2009-10-08 13:24 ` [PATCH 2/6] 8xx: Update TLB asm so it behaves as linux mm expects Joakim Tjernlund
2009-10-08 13:24 ` [PATCH 3/6] 8xx: invalidate non present TLBs Joakim Tjernlund
2009-10-08 13:24 ` [PATCH 4/6] 8xx: Tag DAR with 0x00f0 to catch buggy instructions Joakim Tjernlund
2009-10-08 13:24 ` [PATCH 5/6] 8xx: Fixup DAR from buggy dcbX instructions Joakim Tjernlund
2009-10-08 13:24 ` [PATCH 6/6] 8xx: start using dcbX instructions in various copy routines Joakim Tjernlund
2009-10-08 21:04 ` [PATCH 2/6] 8xx: Update TLB asm so it behaves as linux mm expects Benjamin Herrenschmidt
2009-10-08 22:44 ` Joakim Tjernlund
2009-10-09 0:53 ` Benjamin Herrenschmidt
2009-10-09 6:16 ` Joakim Tjernlund
2009-10-09 6:30 ` Benjamin Herrenschmidt [this message]
2009-10-08 20:48 ` [PATCH 1/6] 8xx: DTLB Error must check for more errors Benjamin Herrenschmidt
2009-10-09 0:15 ` [PATCH 0/6] 8xx MMU fixes Rex Feany
2009-10-09 6:00 ` Joakim Tjernlund
2009-10-09 6:46 ` Rex Feany
2009-10-09 11:04 ` Joakim Tjernlund
2009-10-09 12:30 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255069801.2861.2.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=RFeany@mrv.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).