From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: hs@denx.de
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH, RFC] powerpc, pci: fix MODPOST warning
Date: Wed, 14 Oct 2009 16:47:33 +1100 [thread overview]
Message-ID: <1255499253.2347.40.camel@pasglop> (raw)
In-Reply-To: <4AC99B12.8020005@denx.de>
On Mon, 2009-10-05 at 09:06 +0200, Heiko Schocher wrote:
> Hello,
>
> Heiko Schocher wrote:
> > making a powerpc target with PCI support, shows the
> > following warning:
> >
> > MODPOST vmlinux.o
> > WARNING: vmlinux.o(.text+0x10430): Section mismatch in reference from the function pcibios_allocate_bus_resources() to the function .init.text:reparent_resources()
> > The function pcibios_allocate_bus_resources() references
> > the function __init reparent_resources().
> > This is often because pcibios_allocate_bus_resources lacks a __init
> > annotation or the annotation of reparent_resources is wrong.
> >
> > This patch fix this warning by removing the __init
> > annotation before reparent_resources.
>
> No comments? So, is this fix OK, or unusable?
Nah, just me missing it but it's reference on patchwork. I'll pick
the patch up. We can probably make some of that __devinit instead
of __init though but we can look at it later.
Cheers
Ben.
prev parent reply other threads:[~2009-10-14 5:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 12:45 [PATCH, RFC] powerpc, pci: fix MODPOST warning Heiko Schocher
2009-10-05 7:06 ` Heiko Schocher
2009-10-14 5:47 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255499253.2347.40.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).