From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix compile errors found by new ppc64e_defconfig
Date: Mon, 19 Oct 2009 13:24:07 +0900 [thread overview]
Message-ID: <1255926247.2182.0.camel@pasglop> (raw)
In-Reply-To: <1255910308.4192.8.camel@concordia>
On Mon, 2009-10-19 at 10:58 +1100, Michael Ellerman wrote:
> > if (bus->self) {
> > +#ifdef CONFIG_PPC_STD_MMU_64
> > struct resource *res = bus->resource[0];
> > +#endif
> >
> > pr_debug("IO unmapping for PCI-PCI bridge %s\n",
> > pci_name(bus->self));
> 104
> 105 #ifdef CONFIG_PPC_STD_MMU_64
> 106 __flush_hash_table_range(&init_mm, res->start + _IO_BASE,
> 107 res->end + _IO_BASE + 1);
> 108 #endif
> 109 return 0;
> 110 }
>
> So just expand the ifdef around the pr_debug()?
I'd rather move the pr_debug to after the ifdef, it doesn't need to
absolutely be before the __flush_hash_* call, it's more to see in the
log whether the bus was properly unmapped when doing unplug.
Cheers,
Ben.
next prev parent reply other threads:[~2009-10-19 4:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 17:05 [PATCH] powerpc: Add a Book-3E 64-bit defconfig Kumar Gala
2009-10-16 17:05 ` [PATCH] powerpc: Fix compile errors found by new ppc64e_defconfig Kumar Gala
2009-10-18 23:58 ` Michael Ellerman
2009-10-19 4:24 ` Benjamin Herrenschmidt [this message]
2009-10-16 17:22 ` [PATCH] powerpc: Add a Book-3E 64-bit defconfig Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255926247.2182.0.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).