From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [2/6] Cleanup management of kmem_caches for pagetables
Date: Tue, 27 Oct 2009 15:30:54 +1100 [thread overview]
Message-ID: <1256617854.11607.72.camel@pasglop> (raw)
In-Reply-To: <20091027034602.GB20694@yookeroo.seuss>
On Tue, 2009-10-27 at 14:46 +1100, David Gibson wrote:
>
> The trick is that allocating the PGD and PMD caches is supposed to
> also create the PUD cache, because the PUD index size is always the
> same as either the PGD or PUD cache. If that's not true, we've broken
> the assumptions the code is based on, hence BUG().
Ok, so maybe a little comment with the above explanation concerning
the PUD index size being the same as the PGD or PMD one would be
useful :-)
Cheers,
Ben.
next prev parent reply other threads:[~2009-10-27 4:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 5:21 [0/6] Assorted hugepage cleanups (v3) David Gibson
2009-10-16 5:22 ` [5/6] Split hash MMU specific hugepage code into a new file David Gibson
2009-10-16 5:22 ` [1/6] Make hpte_need_flush() correctly mask for multiple page sizes David Gibson
2009-10-16 5:22 ` [3/6] Allow more flexible layouts for hugepage pagetables David Gibson
2009-10-27 3:10 ` Benjamin Herrenschmidt
2009-10-27 4:56 ` David Gibson
2009-10-16 5:22 ` [6/6] Bring hugepage PTE accessor functions back into sync with normal accessors David Gibson
2009-10-16 5:22 ` [2/6] Cleanup management of kmem_caches for pagetables David Gibson
2009-10-27 2:28 ` Benjamin Herrenschmidt
2009-10-27 3:46 ` David Gibson
2009-10-27 4:30 ` Benjamin Herrenschmidt [this message]
2009-10-16 5:22 ` [4/6] Cleanup initialization of hugepages on powerpc David Gibson
-- strict thread matches above, loose matches on Subject: below --
2009-10-27 5:22 [0/6] Assorted hugepage cleanups (v4) David Gibson
2009-10-27 5:24 ` [2/6] Cleanup management of kmem_caches for pagetables David Gibson
2009-10-29 2:27 ` David Gibson
2009-10-30 3:39 ` David Gibson
2009-10-30 5:05 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256617854.11607.72.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).