From: "Albrecht Dreß" <albrecht.dress@arcor.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Linux PPC Development <linuxppc-dev@ozlabs.org>,
Devicetree Discussions <devicetree-discuss@lists.ozlabs.org>,
Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCHv2 3/3] mpc52xx/wdt: remove obsolete old WDT implementation
Date: Thu, 12 Nov 2009 21:36:42 +0100 [thread overview]
Message-ID: <1258058202.2192.1@antares> (raw)
In-Reply-To: <20091112195646.GB13350@pengutronix.de> (from w.sang@pengutronix.de on Thu Nov 12 20:56:46 2009)
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
Hi Wolfram:
Am 12.11.09 20:56 schrieb(en) Wolfram Sang:
> > Note: The file drivers/watchdog/mpc5200_wdt.c is now obsolete and should be removed.
>
> Ehrm, this is possible within a patch :)
Ummm, I tried that (removed the file from git locally), but apparently I'm too dumb to find the proper options to get this into the diff (to my defence, I'm still using cvs/svn for my projects). Can you give me a hint?
> > config MPC5200_WDT
> > - tristate "MPC5200 Watchdog Timer"
> > + bool "MPC52xx Watchdog Timer"
> > depends on PPC_MPC52xx
> > + help
> > + Use General Purpose Timer (GPT) 0 on the MPC5200 as Watchdog.
>
> s/5200/52xx/ here too.
Yes, you're right. The config option should still be 'MPC5200_WDT', though, as otherwise all the default configs had to be touched - IMO, on the low level, this does no harm. Thoughts?
Cheers, Albrecht.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2009-11-12 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 18:45 [PATCHv2 3/3] mpc52xx/wdt: remove obsolete old WDT implementation Albrecht Dreß
2009-11-12 19:14 ` Grant Likely
2009-11-12 19:56 ` Wolfram Sang
2009-11-12 20:36 ` Albrecht Dreß [this message]
2009-11-12 20:43 ` Grant Likely
2009-11-12 20:47 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258058202.2192.1@antares \
--to=albrecht.dress@arcor.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=w.sang@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).