From: John Bonesio <bones@secretlab.ca>
To: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: mpc5200 ata driver question
Date: Fri, 13 Nov 2009 14:13:36 -0800 [thread overview]
Message-ID: <1258150416.19600.16.camel@riker> (raw)
Hello,
I have seen an intermittent problem in the driver:
drivers/ata/pata_mpc52xx.c
The intermittent error is that the bestcomm dma engine gets stuck. I
don't believe the driver itself is causing the dma error. However, I do
want to enhance the driver so that it can recover from the dma error and
continue operation.
I haven't been able to find much information on the ata driver layer
other than the code. I've looked through and run some test code. The ata
layer will call either the driver's softreset() or hardreset() operation
if an error is detected.
I'm thinking about adding one or both of these reset routines, but I'm
not sure if this is the right approach since the error isn't with the
ata device itself. An alternative could be to recover dma from
mpc52xx_bmdma_status() - when the error is detected and reported.
How is error recovery supposed to work in the ata layer, and what is the
best approach for recovering from a dma error (as opposed to a drive
error)?
What is supposed to be the difference between the softreset() and
hardreset() routines? If recovering from the dma error, would one of
these routines be better to use?
Thanks for your help,
- John
reply other threads:[~2009-11-13 22:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258150416.19600.16.camel@riker \
--to=bones@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox