From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 19AF91007D3 for ; Wed, 2 Dec 2009 11:01:18 +1100 (EST) Subject: Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller From: Benjamin Herrenschmidt To: Tejun Heo In-Reply-To: <4B15AA4F.5040309@kernel.org> References: <20091201070834.6A840B7B63@ozlabs.org> <4B14CD22.4020806@kernel.org> <1259709552.2076.1053.camel@pasglop> <4B15A67C.2030102@kernel.org> <1259710543.2076.1054.camel@pasglop> <4B15AA4F.5040309@kernel.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 02 Dec 2009 11:00:27 +1100 Message-ID: <1259712027.2076.1055.camel@pasglop> Mime-Version: 1.0 Cc: linux-ide@vger.kernel.org, Holger Macht , linuxppc-dev@lists.ozlabs.org, Jeff Garzik List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2009-12-02 at 08:44 +0900, Tejun Heo wrote: > > BTW. For a plug event, what should I do ? freeze is fine ? Or just > > schedule eh ? Right now, when plugging I see an exception Emask 0x10 > > etc... message in the log when plugging which isn't totally nice :-) > > freeze() and please don't fight the EH messages from low level driver. > If it's too much, we need to update core layer but given the variety > of phy related bugs, I think we need those messages. Eh, ok :-) No biggie. Cheers, Ben.