From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Albert Herranz <albert_herranz@yahoo.es>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v2 09/11] powerpc: gamecube/wii: flipper interrupt controller support
Date: Thu, 03 Dec 2009 07:56:41 +1100 [thread overview]
Message-ID: <1259787401.2076.1159.camel@pasglop> (raw)
In-Reply-To: <4B15731E.3000109@yahoo.es>
On Tue, 2009-12-01 at 20:48 +0100, Albert Herranz wrote:
>
> This -1 should be NO_IRQ too.
> I'll fix this in the next version.
No. The number you pass here is not a linux virq number, but a number in
your HW numbering space that never represents a valid IRQ. In your case
0 (NO_IRQ is deprecated anyways) is a valid HW interrupt number. However
-1 sounds good.
So your existing code is fine.
Cheers,
Ben.
next prev parent reply other threads:[~2009-12-02 20:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 20:43 [RFC PATCH v2 00/11] powerpc: nintendo gamecube support Albert Herranz
2009-11-28 20:43 ` [RFC PATCH v2 01/11] powerpc: gamecube/wii: usbgecko bootwrapper console support Albert Herranz
2009-12-01 18:28 ` Segher Boessenkool
2009-11-28 20:43 ` [RFC PATCH v2 02/11] powerpc: gamecube: device tree Albert Herranz
2009-12-01 18:29 ` Segher Boessenkool
2009-11-28 20:43 ` [RFC PATCH v2 03/11] powerpc: gamecube: bootwrapper bits Albert Herranz
2009-12-01 18:31 ` Segher Boessenkool
2009-11-28 20:43 ` [RFC PATCH v2 04/11] powerpc: gamecube/wii: introduce GAMECUBE_COMMON Albert Herranz
2009-11-28 20:43 ` [RFC PATCH v2 05/11] powerpc: gamecube/wii: declare as non-coherent platforms Albert Herranz
2009-11-28 20:43 ` [RFC PATCH v2 06/11] powerpc: gamecube/wii: do not include PCI support Albert Herranz
2009-11-28 20:43 ` [RFC PATCH v2 07/11] powerpc: gamecube/wii: udbg support for usbgecko Albert Herranz
2009-12-01 18:33 ` Segher Boessenkool
2009-11-28 20:43 ` [RFC PATCH v2 08/11] powerpc: gamecube/wii: early debugging using usbgecko Albert Herranz
2009-11-29 23:18 ` Benjamin Herrenschmidt
2009-11-30 5:50 ` Albert Herranz
2009-11-30 6:14 ` Benjamin Herrenschmidt
2009-11-30 6:28 ` Albert Herranz
2009-11-30 6:42 ` Benjamin Herrenschmidt
2009-11-30 6:15 ` Albert Herranz
2009-11-28 20:43 ` [RFC PATCH v2 09/11] powerpc: gamecube/wii: flipper interrupt controller support Albert Herranz
2009-11-29 23:21 ` Benjamin Herrenschmidt
2009-12-01 18:35 ` Segher Boessenkool
2009-12-01 19:48 ` Albert Herranz
2009-12-02 20:56 ` Benjamin Herrenschmidt [this message]
2009-12-02 23:29 ` Albert Herranz
2009-11-28 20:43 ` [RFC PATCH v2 10/11] powerpc: gamecube: platform support Albert Herranz
2009-11-28 20:43 ` [RFC PATCH v2 11/11] powerpc: gamecube: default config Albert Herranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259787401.2076.1159.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=albert_herranz@yahoo.es \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).