From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3F821B7BF7 for ; Thu, 3 Dec 2009 14:00:17 +1100 (EST) Subject: Re: [PATCH] [SCSI] mpt fusion: Fix 32 bit platforms with 64 bit resources. From: Benjamin Herrenschmidt To: Pravin Bathija In-Reply-To: <1259805106-23636-1-git-send-email-pbathija@amcc.com> References: <1259805106-23636-1-git-send-email-pbathija@amcc.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 03 Dec 2009 13:59:50 +1100 Message-ID: <1259809190.2076.1194.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Eric.Moore@lsi.com, linux-scsi@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2009-12-02 at 17:51 -0800, Pravin Bathija wrote: > Powerpc 44x uses 36 bit real address while the real address defined > in MPT Fusion driver is of type 32 bit. This causes ioremap to fail and driver > fails to initialize. This fix changes the data types representing the real > address from unsigned long 32-bit types to resource_size_t which is 64-bit. The > driver has been tested, the disks get discovered correctly and can do IO. > > Signed-off-by: Pravin Bathija Acked-by: Benjamin Herrenschmidt --- James, this one should be good ;-) > Acked-by: Feng Kan > Acked-by: Fushen Chen > Acked-by: Loc Ho > Acked-by: Tirumala Reddy Marri > Acked-by: Victor Gallardo > --- > drivers/message/fusion/mptbase.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c > index 5d496a9..9f14a60 100644 > --- a/drivers/message/fusion/mptbase.c > +++ b/drivers/message/fusion/mptbase.c > @@ -1511,7 +1511,7 @@ mpt_mapresources(MPT_ADAPTER *ioc) > { > u8 __iomem *mem; > int ii; > - unsigned long mem_phys; > + resource_size_t mem_phys; > unsigned long port; > u32 msize; > u32 psize;